public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat.com>
To: Ben Elliston <bje@redhat.com>
Cc: sid@sources.redhat.com
Subject: Re: CPU disassembler-memory accessor
Date: Wed, 29 May 2002 08:53:00 -0000	[thread overview]
Message-ID: <20020529115301.C17962@redhat.com> (raw)
In-Reply-To: <15604.59813.750421.114817@tooth.toronto.redhat.com>; from bje@redhat.com on Wed, May 29, 2002 at 10:45:57AM -0400

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

Hi -

bje wrote:
> [...]
> The following patch adds a third accessor to CPUs for the purpose of
> providing the disassembler with access to the instruction memory
> without causing undesirable side effects in the memory hierarchy.
> [...]

Thanks.

> [...] Any comments?

Yes, just one.  The read_disasm_memory_1 function is methinks
overengineered.  It doesn't need to throw exceptions, nor handle
accesses of other sizes.  Actually, why not just do a direct
sid::bus-level read() on the accessor and do away with the
read_disasm_memory* thingie altogether?


- FChE

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

  reply	other threads:[~2002-05-29 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-29  7:46 Ben Elliston
2002-05-29  8:53 ` Frank Ch. Eigler [this message]
2002-05-31 13:35   ` Ben Elliston
2002-05-31 13:39     ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020529115301.C17962@redhat.com \
    --to=fche@redhat.com \
    --cc=bje@redhat.com \
    --cc=sid@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).