From: "Frank Ch. Eigler" <fche@redhat.com>
To: Dave Brolley <brolley@redhat.com>
Cc: sid@sources.redhat.com
Subject: Re: [patch][rfa] Add "active" pin to sid-sched
Date: Fri, 29 Aug 2003 16:16:00 -0000 [thread overview]
Message-ID: <20030829161600.GA32244@redhat.com> (raw)
In-Reply-To: <3F4F7AE9.10906@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
Hi -
> [...]
> OK to commit?
Looks fine to commit, though please consider not using a new
"active_p" member variable in order to send edges on the active
pin. This can be done by replacing ...
> + // Drive the active pin if the threshold has been crossed.
> + if (UNLIKELY(! this->active_p))
> + {
> + this->active_pin.drive (1);
> + this->active_p = true;
> + }
> +
with
if (this->active_pin.sense() != 1)
this->active_pin->drive(1);
and a corresponding change for the 0 transition.
- FChE
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-08-29 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-29 16:09 Dave Brolley
2003-08-29 16:16 ` Frank Ch. Eigler [this message]
2003-08-29 19:44 ` Dave Brolley
2003-08-29 19:47 ` Frank Ch. Eigler
2003-08-29 20:23 ` Dave Brolley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030829161600.GA32244@redhat.com \
--to=fche@redhat.com \
--cc=brolley@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).