From: John Wehle <john@feith.com>
To: sid@sources.redhat.com
Subject: sid-20110801 Patch to fix cache lru updating during expell
Date: Sun, 16 Oct 2011 07:58:00 -0000 [thread overview]
Message-ID: <201110160505.p9G555gU025589@jwlab.FEITH.COM> (raw)
Currently when the SID cache lru component replaces a line it just sets
the age of that line to zero without updating the age of any of the other
lines. This means that if there are a series of cache misses, then there
will be a series of new lines having the same age preventing the lru policy
from being able to work correctly.
The enclosed patch has been tested on FreeBSD with sid configured for
tomi Borealis (a processor under development by Venray Technology).
ChangeLog:
Sun Oct 16 00:39:23 EDT 2011 John Wehle (john@feith.com)
* component/cache/cache.cxx (cache_replacement_lru::expell):
Update the age of all the lines.
-- John
------------------------8<------------------------------8<---------------
--- component/cache/cache.cxx.ORIGINAL 2009-04-08 16:39:34.000000000 -0400
+++ component/cache/cache.cxx 2011-10-13 00:22:20.000000000 -0400
@@ -1052,7 +1050,15 @@ cache_replacement_lru::expell (cache_set
if (index < 0)
return 0;
- lru[index] = 0;
+ // update state by hand since the tag may not be set properly
+ for (unsigned i = 0; i < cset.num_lines (); i++)
+ {
+ if (i == index)
+ lru[i] = 0;
+ else
+ lru[i]++;
+ }
+
return &cset.get_line (index);
}
-------------------------------------------------------------------------
WARNING: multiple messages have this Message-ID
From: John Wehle <john@feith.com>
To: sid@sources.redhat.com
Subject: sid-20110801 Patch to fix cache lru updating during expell
Date: Thu, 27 Oct 2011 04:16:00 -0000 [thread overview]
Message-ID: <201110160505.p9G555gU025589@jwlab.FEITH.COM> (raw)
Message-ID: <20111027041600.q-vAuxdx9rMfkCy6QnW5shgQQWOylwalBzR7ydnE9UU@z> (raw)
Currently when the SID cache lru component replaces a line it just sets
the age of that line to zero without updating the age of any of the other
lines. This means that if there are a series of cache misses, then there
will be a series of new lines having the same age preventing the lru policy
from being able to work correctly.
The enclosed patch has been tested on FreeBSD with sid configured for
tomi Borealis (a processor under development by Venray Technology).
ChangeLog:
Sun Oct 16 00:39:23 EDT 2011 John Wehle (john@feith.com)
* component/cache/cache.cxx (cache_replacement_lru::expell):
Update the age of all the lines.
-- John
------------------------8<------------------------------8<---------------
--- component/cache/cache.cxx.ORIGINAL 2009-04-08 16:39:34.000000000 -0400
+++ component/cache/cache.cxx 2011-10-13 00:22:20.000000000 -0400
@@ -1052,7 +1050,15 @@ cache_replacement_lru::expell (cache_set
if (index < 0)
return 0;
- lru[index] = 0;
+ // update state by hand since the tag may not be set properly
+ for (unsigned i = 0; i < cset.num_lines (); i++)
+ {
+ if (i == index)
+ lru[i] = 0;
+ else
+ lru[i]++;
+ }
+
return &cset.get_line (index);
}
-------------------------------------------------------------------------
next reply other threads:[~2011-10-16 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 7:58 John Wehle [this message]
2011-10-27 4:16 ` John Wehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110160505.p9G555gU025589@jwlab.FEITH.COM \
--to=john@feith.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).