From: Dave Brolley <brolley@redhat.com>
To: Ben Elliston <bje@wasabisystems.com>
Cc: sid@sources.redhat.com
Subject: Re: [patch] ELF loader
Date: Fri, 13 Feb 2004 15:17:00 -0000 [thread overview]
Message-ID: <402CEA85.9010109@redhat.com> (raw)
In-Reply-To: <87r7wz65fw.fsf@wasabisystems.com>
Ben Elliston wrote:
>Dave Brolley <brolley@redhat.com> writes:
>
>
>
>>I'm committing the attached patch which requirks the ELF loader to
>>correct the following problems:
>>
>>
>
>This looks mostly fine, however I have one question: where is the
>dependency on libiberty introduced and can it be avoided?
>
>
I used xrealloc to allocate loadAreas and textSections. It used to be an
unchecked hard coded limit of 100 elements each. I figured that using
libiberty was ok since it's already used by sid/component/cgen-cpu.
That's where I got the Makefile.am changes.
It could be avoided by using realloc and checking for failure. I guess
failure would have to result in an abort?
Dave
next prev parent reply other threads:[~2004-02-13 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-12 20:29 Dave Brolley
2004-02-12 20:45 ` Dave Brolley
2004-02-12 22:49 ` Ben Elliston
2004-02-13 3:09 ` Ben Elliston
2004-02-13 15:17 ` Dave Brolley [this message]
2004-02-13 17:57 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=402CEA85.9010109@redhat.com \
--to=brolley@redhat.com \
--cc=bje@wasabisystems.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).