public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
From: Dave Brolley <brolley@redhat.com>
To: Dave Brolley <brolley@redhat.com>
Cc: sid@sources.redhat.com, cgen@sources.redhat.com
Subject: Re: [patch][rfa] SID cpu tracing -- attempt #2
Date: Mon, 22 Mar 2004 21:40:00 -0000	[thread overview]
Message-ID: <405F5D2E.6070008@redhat.com> (raw)
In-Reply-To: <405F3AB6.1020707@redhat.com>

Approved by fche and committed.

Dave Brolley wrote:

> Hi,
>
> Reponding to Frank's concerns about my previous patch, here is an 
> implementation along the lines he suggested. The idea is that each 
> CGEN 'set' handler and each component which is the target of a store 
> operation is responsible to annotating the cpu trace with the actual 
> value stored, if desired. In order to accomplish this, two changes 
> were necessary.
>
> 1) The tracing code generated by CGEN is now generated before the code 
> for the semantic operation. That way any annotation appears after the 
> original cpu trace.
>
> 2) basic_cpu now has a "trace" pin for use by other components. Each 
> value driven on the pin will be echoed as a character into the cpu's 
> trace_stream. This way annotation by other components are merged 
> properly with the cpu trace whether it be to cout or to a file.
>
> I've attached sid-trace-cgen.patch.txt which shows the CGEN changes 
> and a partial diff of the resulting changes to xstormy16-sem.cxx. I've 
> also attached sid-trace.patch.txt which shows the changes to basic_cpu.
>
> Tested on an internal port which requirs this functionality.
>
> OK to commit?
>
> Dave



      reply	other threads:[~2004-03-22 21:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-22 19:13 Dave Brolley
2004-03-22 21:40 ` Dave Brolley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=405F5D2E.6070008@redhat.com \
    --to=brolley@redhat.com \
    --cc=cgen@sources.redhat.com \
    --cc=sid@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).