From: Dave Brolley <brolley@redhat.com>
To: sid@sources.redhat.com
Subject: [patch][commit] ISO C++ Compliance
Date: Wed, 17 Jan 2007 20:57:00 -0000 [thread overview]
Message-ID: <45AE8D98.1000206@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
Hi,
I've committed the attached patch which allows compilation with recent
more strict ISO C++ compliance by gcc. The typedef is referenced by an
inheriting class and, so, must be protected, not private.
Dave
[-- Attachment #2: sid.iso.ChangeLog --]
[-- Type: text/plain, Size: 118 bytes --]
2007-01-17 Dave Brolley <brolley@redhat.com>
* sidbusutil.h (value_control_register::ValueType): Now
protected.
[-- Attachment #3: sid.iso.patch.txt --]
[-- Type: text/plain, Size: 772 bytes --]
Index: sid/include/sidbusutil.h
===================================================================
RCS file: /cvs/src/src/sid/include/sidbusutil.h,v
retrieving revision 1.16
diff -c -p -r1.16 sidbusutil.h
*** sid/include/sidbusutil.h 2 Aug 2005 18:53:10 -0000 1.16
--- sid/include/sidbusutil.h 11 Jan 2007 19:10:33 -0000
*************** namespace sidutil
*** 730,736 ****
template <typename DataType>
class value_control_register: public control_register<DataType>
{
! private:
typedef typename DataType::value_type ValueType;
public:
--- 730,736 ----
template <typename DataType>
class value_control_register: public control_register<DataType>
{
! protected:
typedef typename DataType::value_type ValueType;
public:
reply other threads:[~2007-01-17 20:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AE8D98.1000206@redhat.com \
--to=brolley@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).