From: Greg McGary <greg@mcgary.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: cgen@sources.redhat.com, sid@sources.redhat.com
Subject: Re: branch probability hinting
Date: Wed, 28 Feb 2001 15:01:00 -0000 [thread overview]
Message-ID: <mswvaajtuo.fsf@mcgary.org> (raw)
In-Reply-To: <20010228173521.A14580@redhat.com>
"Frank Ch. Eigler" <fche@redhat.com> writes:
> One is used thusly (and the other, vice versa):
> [ ... ]
> if UNLIKELY(error) {
Cool. Only one nit to pick:
Please don't encourage people to write code that appears to be
syntactically invalid. I know that the parens are part of the
expansion of LIKELY & UNLIKELY, but lexical tools such as indent get
confused. I'd rather see uses like this:
if (UNLIKELY(error)) {
Greg
next prev parent reply other threads:[~2001-02-28 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-28 14:35 Frank Ch. Eigler
2001-02-28 15:01 ` Greg McGary [this message]
2001-02-28 16:37 ` matthew green
[not found] ` <6863.983407030.cygnus.local.cgen@cygnus.com>
2001-02-28 16:50 ` Eric Christopher
2001-02-28 17:04 ` matthew green
2001-03-01 9:13 ` Frank Ch. Eigler
2001-03-01 9:21 ` Dave Brolley
2001-03-01 9:32 ` Greg McGary
2001-03-01 9:26 ` Greg McGary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mswvaajtuo.fsf@mcgary.org \
--to=greg@mcgary.org \
--cc=cgen@sources.redhat.com \
--cc=fche@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).