From: Jim Blandy <jimb@redhat.com>
To: sid@sources.redhat.com
Subject: Re: PATCH: fix up fake BFD functions in cgen-cpu/tracedis.cxx
Date: Fri, 26 Mar 2004 20:24:00 -0000 [thread overview]
Message-ID: <vt2y8pnpdb2.fsf@zenia.home> (raw)
In-Reply-To: <vt21xnjyx94.fsf@zenia.home>
I've committed this.
Jim Blandy <jimb@redhat.com> writes:
> In trying to build SID with --disable-shared, I found that linking
> 'sid' died because the references to these functions in libopcodes
> weren't being satisfied. As it turns out:
>
> $ nm tracedis.o | grep bfd_get_bits
> 000024de T _Z12bfd_get_bitsPhii
> $
>
> But when I added the 'extern "C"' thingies, the compiler was suddenly
> able to check the definitions against the declarations in bfd/bfd.h
> again. Those changed recently; see Alan Modra's 2004-03-15 change in
> bfd/ChangeLog.
>
> 2004-03-23 Jim Blandy <jimb@redhat.com>
>
> * tracedis.cxx (bfd_get_arch, bfd_getb16, bfd_getl16, bfd_getb32)
> (bfd_getl32, bfd_put_bits, bfd_get_bits, bfd_lookup_arch): These
> definitions are meant to satisfy references in libopcodes, which
> is C code, so declare these with 'extern "C"'. Adjust types to
> match those declared in the BFD header file.
prev parent reply other threads:[~2004-03-26 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-23 23:13 Jim Blandy
2004-03-26 20:24 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2y8pnpdb2.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).