Bugfix for sorting problem in the symbol browser

Bugfix for sorting problem in the symbol browser

[Khamis Abuelkomboz (UUNET)]

This patch applies to SN5.0 and SN4.52.

The whole file is located at http://home.knuut.de/sn/compare.c
Please notice that it uses the same compare conditions like the
column sorting...
You can download the binaries with this change for windows platforms:
http://home.knuut.de/sn/sn452/hyper.exe
http://home.knuut.de/sn/sn50/hyper.exe

PATCH-Output for the fixed file <SRC>/snavigator/hyper/compare.c:

+++ compare.c   Mon Apr 23 09:46:47 2001
@@ -23,8 +23,10 @@

  */

+#include <config.h>
  #include <ctype.h>
  #include "tclInt.h"
+#include "tkInt.h"

  /*
   *----------------------------------------------------------------------
@@ -79,44 +81,12 @@
      right++;
    }

-  for ( ; (*left != '\0') && (*right != '\0'); left++, right++) {
-    if (*left == *right) {
-      continue;
-    }
-
-    leftCh = toupper(*left);
-    rightCh = toupper(*right);
-
-    if (leftCh < rightCh) {
-      Tcl_SetIntObj(Tcl_GetObjResult(interp), -1);
-      return TCL_OK;
-    } else if (rightCh < leftCh) {
-      Tcl_SetIntObj(Tcl_GetObjResult(interp), 1);
-      return TCL_OK;
-    } else {
-      /* `A' is less than `a'. */
-      if (isupper(*left) && islower(*right)) {
-       Tcl_SetIntObj(Tcl_GetObjResult(interp), -1);
-       return TCL_OK;
-      }
-      /* `a' is greater than `A'. */
-      if (islower(*left) && isupper(*right)) {
-       Tcl_SetIntObj(Tcl_GetObjResult(interp), 1);
-       return TCL_OK;
-      }
-    }
-  }
-
-  if (*left == '\0') {
-    if (*right == '\0') {
-      Tcl_SetIntObj(Tcl_GetObjResult(interp), 0);
-    } else {
-      Tcl_SetIntObj(Tcl_GetObjResult(interp), -1);
+  dummy = (tolower(*left) - tolower(*right));
+  if (dummy == 0 && *left != '\0')
+    {
+      dummy = strcasecmp (left + 1, right + 1);
      }
-  } else {
-    Tcl_SetIntObj(Tcl_GetObjResult(interp), 1);
-  }
-
+  Tcl_SetIntObj(Tcl_GetObjResult(interp), dummy);
    return TCL_OK;
  }

Re: Bugfix for sorting problem in the symbol browser

[Khamis Abuelkomboz (UUNET)]

Ups, the URLS are

Khamis Abuelkomboz (UUNET) wrote:

> The whole file is located at http://home.knuut.de/sn/compare.c
http://home.knuut.de/khamis/sn/compare.c

> http://home.knuut.de/sn/sn452/hyper.exe
> http://home.knuut.de/sn/sn50/hyper.exe

http://home.knuut.de/khamis/sn/sn452/hyper.exe
http://home.knuut.de/khamis/sn/sn50/hyper.exe

Using Nedit, gvim, etc Editors with Snav 4.x

[Bill Munday]

Hi,

Up till now I have been happy with SN Editor until recently where it has
started to mess up syntax highlighting, an nor can it highlight sam files.

How do I use another editor and still maintain the jumping to errors
during the build step?

As changing the Preferences - EDIT = external editor does not give a clean
integration.

Thanks
Bill

PS How comes no one aswered my previous emails?
PS2 Have you thought about docking the windows like Microsoft VC6

Re: Using Nedit, gvim, etc Editors with Snav 4.x

[Ian Roxborough]

Bill Munday wrote:
> Up till now I have been happy with SN Editor until recently where it has
> started to mess up syntax highlighting, an nor can it highlight sam files.

SN doesn't know anything about sam files (I don't either for that matter).
However, if you can produce a short reproducible test case for the
highlighting problem, then it's a step closer to being fixed.

> How do I use another editor and still maintain the jumping to errors
> during the build step?

Emacs is meant to have that level of integration, however it's
possible that the Emacs integration is broken.  Current, I don't
think there are any other editors that could work like that.
 
> As changing the Preferences - EDIT = external editor does not give a clean
> integration.

Yeah, that level of integration would require adding an editor interface
layer that can control either an existing SN editor or be ported to
control 3rd party editors.

> PS How comes no one aswered my previous emails?

I didn't have a good answer.

Ian.

Re: Using Nedit, gvim, etc Editors with Snav 4.x

[Mo DeJong]

On Thu, 26 Apr 2001, Bill Munday wrote:

> Hi,
> 
> Up till now I have been happy with SN Editor until recently where it has
> started to mess up syntax highlighting, an nor can it highlight sam files.
> 
> How do I use another editor and still maintain the jumping to errors
> during the build step?

I think that is covered here:

http://sources.redhat.com/sourcenav/online-docs/userguide/editor.html#pgfId-1075901

> As changing the Preferences - EDIT = external editor does not give a clean
> integration.

Could you explain what you mean by that? An external editor is by
definition not integrated.

Mo