snavigator on Linux Sparc64

snavigator on Linux Sparc64

[root]

Hi,

   I have download the snavigator on a Linux Sparc64 (Ultra 5) and I try
to compile it.
I get two errors in the tclPosixStr.c file due to duplicate case value
(SIGLOST and SIGPWR).
In /usr/include/bits/signum.h we have the following definitions:
    #define SIGLOST 29
    #define SIGPWR SIGLOST

Due to this definitions I get the error mentioned above. When looking at
the code we have:

#if defined(SIGLOST) && (!defined(SIGIOT) || (SIGLOST != SIGIOT)) &&
(!defined(SIGURG) || (SIGLOST != SIGURG)) && (!defined(SIGPROF) ||
(SIGLOST != SIGPROF)) && (!defined(SIGIO) || (SIGLOST != SIGIO))
        case SIGLOST: return "SIGLOST";

and

#if defined(SIGPWR) && (!defined(SIGXFSZ) || (SIGPWR != SIGXFSZ)))
        case SIGPWR: return "SIGPWR";

We can see clearly that this is causing the error.

Now, to fix this error I change the SIGPWR line to:

#if defined(SIGPWR) && (!defined(SIGXFSZ) || (SIGPWR != SIGXFSZ)) &&
(!defined(SIGLOST) || (SIGPWR != SIGLOST))
        case SIGPWR: return "SIGPWR";

But I do not know the impact of this change in the code and on other
systems. It may be more appropriate to add the
!defined(SIGPWR) || (SIGLOST != SIGPWR) to the SIGLOST define
statement.
I would apreciate if you can let me know if this chande is OK or not.

Thanks,
Dan

Re: snavigator on Linux Sparc64

[Mo DeJong]

On Wed, 2 Aug 2000, root wrote:

> Hi,
> 
>    I have download the snavigator on a Linux Sparc64 (Ultra 5) and I try
> to compile it.
> I get two errors in the tclPosixStr.c file due to duplicate case value
> (SIGLOST and SIGPWR).
> In /usr/include/bits/signum.h we have the following definitions:
>     #define SIGLOST 29
>     #define SIGPWR SIGLOST
> 
> Due to this definitions I get the error mentioned above. When looking at
> the code we have:
> 
> #if defined(SIGLOST) && (!defined(SIGIOT) || (SIGLOST != SIGIOT)) &&
> (!defined(SIGURG) || (SIGLOST != SIGURG)) && (!defined(SIGPROF) ||
> (SIGLOST != SIGPROF)) && (!defined(SIGIO) || (SIGLOST != SIGIO))
>         case SIGLOST: return "SIGLOST";
> 
> and
> 
> #if defined(SIGPWR) && (!defined(SIGXFSZ) || (SIGPWR != SIGXFSZ)))
>         case SIGPWR: return "SIGPWR";
> 
> We can see clearly that this is causing the error.
> 
> Now, to fix this error I change the SIGPWR line to:
> 
> #if defined(SIGPWR) && (!defined(SIGXFSZ) || (SIGPWR != SIGXFSZ)) &&
> (!defined(SIGLOST) || (SIGPWR != SIGLOST))
>         case SIGPWR: return "SIGPWR";
> 
> But I do not know the impact of this change in the code and on other
> systems. It may be more appropriate to add the
> !defined(SIGPWR) || (SIGLOST != SIGPWR) to the SIGLOST define
> statement.
> I would apreciate if you can let me know if this chande is OK or not.
> 
> Thanks,
> Dan


Could you compare your changes to the most recent CVS version
of Tcl/Tk in the Ajuba CVS? I think there were some Sparc Linux
fixes that have already been applied.

http://dev.scriptics.com/software/tcltk/netcvs.html

Mo DeJong
Red Hat Inc

Re: snavigator on Linux Sparc64

[Mo DeJong]

On Thu, 3 Aug 2000, Ben Elliston wrote:

>    Could you compare your changes to the most recent CVS version of
>    Tcl/Tk in the Ajuba CVS? I think there were some Sparc Linux fixes
>    that have already been applied.
> 
> Nevertheless, this problem is solely in Tcl.  I would be surprised if Ajuba
> haven't fix it by now--in which case, we could import the patch.
> 
> Ben

Yes, but it would be nice if we could get someone to test changes
out to make sure it works before we apply them. We do not have
a sparc Linux machine here in the SOMA office, so we can't
really test it.

Mo DeJong
Red Hat Inc

Re: snavigator on Linux Sparc64

[Ben Elliston]

   Could you compare your changes to the most recent CVS version of
   Tcl/Tk in the Ajuba CVS? I think there were some Sparc Linux fixes
   that have already been applied.

Nevertheless, this problem is solely in Tcl.  I would be surprised if Ajuba
haven't fix it by now--in which case, we could import the patch.

Ben

Re: snavigator on Linux Sparc64

[root]

Mo DeJong wrote:

> On Thu, 3 Aug 2000, Ben Elliston wrote:
>
> >    Could you compare your changes to the most recent CVS version of
> >    Tcl/Tk in the Ajuba CVS? I think there were some Sparc Linux fixes
> >    that have already been applied.
> >
> > Nevertheless, this problem is solely in Tcl.  I would be surprised if Ajuba
> > haven't fix it by now--in which case, we could import the patch.
> >
> > Ben
>
> Yes, but it would be nice if we could get someone to test changes
> out to make sure it works before we apply them. We do not have
> a sparc Linux machine here in the SOMA office, so we can't
> really test it.
>
> Mo DeJong
> Red Hat Inc

If you wish, I could try to help you out with the changes.

Also, I have download the tcl8.4a1 version and they already fix this in the tcl
sources !

Dan

Re: snavigator on Linux Sparc64

[Ben Elliston]

Hi,

Firstly, can I suggest you change your "real name" to something other than
root?  It's bloody confusing to see mail in my inbox that's not from root on
my own system!

   If you wish, I could try to help you out with the changes.

That'd be great.

   Also, I have download the tcl8.4a1 version and they already fix this
   in the tcl sources !

I figured as much.  Is there a specific patch for this, or is it just
bundled in with the rest of 8.4?

Ben

Re: snavigator on Linux Sparc64

[Mo DeJong]

On Thu, 3 Aug 2000, root wrote:

> Mo DeJong wrote:
> 
> > On Thu, 3 Aug 2000, Ben Elliston wrote:
> >
> > >    Could you compare your changes to the most recent CVS version of
> > >    Tcl/Tk in the Ajuba CVS? I think there were some Sparc Linux fixes
> > >    that have already been applied.
> > >
> > > Nevertheless, this problem is solely in Tcl.  I would be surprised if Ajuba
> > > haven't fix it by now--in which case, we could import the patch.
> > >
> > > Ben
> >
> > Yes, but it would be nice if we could get someone to test changes
> > out to make sure it works before we apply them. We do not have
> > a sparc Linux machine here in the SOMA office, so we can't
> > really test it.
> >
> > Mo DeJong
> > Red Hat Inc
> 
> If you wish, I could try to help you out with the changes.
> 
> Also, I have download the tcl8.4a1 version and they already fix this in the tcl
> sources !
> 
> Dan


So, does SN work "out of the box" on Sparc Linux if
you apply this patch?

Index: tclPosixStr.c
===================================================================
RCS file: /home/cvs/external/tcl/generic/tclPosixStr.c,v
retrieving revision 1.5
diff -u -r1.5 tclPosixStr.c
--- tclPosixStr.c	1999/08/21 19:41:04	1.5
+++ tclPosixStr.c	2000/08/04 02:34:45
@@ -986,7 +986,7 @@
 #ifdef SIGPROF
 	case SIGPROF: return "SIGPROF";
 #endif
-#if defined(SIGPWR) && (!defined(SIGXFSZ) || (SIGPWR != SIGXFSZ))
+#if defined(SIGPWR) && (!defined(SIGXFSZ) || (SIGPWR != SIGXFSZ)) && 
(!defined(SIGLOST) || (SIGPWR != SIGLOST))
 	case SIGPWR: return "SIGPWR";
 #endif
 #ifdef SIGQUIT
@@ -1118,7 +1118,7 @@
 #ifdef SIGPROF
 	case SIGPROF: return "profiling alarm";
 #endif
-#if defined(SIGPWR) && (!defined(SIGXFSZ) || (SIGPWR != SIGXFSZ))
+#if defined(SIGPWR) && (!defined(SIGXFSZ) || (SIGPWR != SIGXFSZ)) && 
(!defined(SIGLOST) || (SIGPWR != SIGLOST))
 	case SIGPWR: return "power-fail restart";
 #endif
 #ifdef SIGQUIT


Mo DeJong
Red Hat Inc