public inbox for sourcenav@sourceware.org
 help / color / mirror / Atom feed
* private variables, methods, etc.
@ 2001-07-04 19:11 Celia McInnis
  2001-07-05 18:09 ` Mo DeJong
  0 siblings, 1 reply; 2+ messages in thread
From: Celia McInnis @ 2001-07-04 19:11 UTC (permalink / raw)
  To: Source Navigator

Hi:

I really love Source-Navigator - especially the fact that we can extend
its functionality in many ways without having to change the
Source-Navigator source code.

Could you consider making more (or maybe even all?) of the methods and
variables public rather than private?

Recently I needed to be able to access the value of text_current_line
from the select_current_line method and found it necessary to override
the whole Make class in order to get it. Seemed a shame to have to
override 1000+ lines of code (which I'll then have/want  to keep in sync
with redhat upgrades) when all I needed was to stick in one global
statement...

Thanks for your consideration,
Celia McInnis

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: private variables, methods, etc.
  2001-07-04 19:11 private variables, methods, etc Celia McInnis
@ 2001-07-05 18:09 ` Mo DeJong
  0 siblings, 0 replies; 2+ messages in thread
From: Mo DeJong @ 2001-07-05 18:09 UTC (permalink / raw)
  To: sourcenav

On Wed, 4 Jul 2001, Celia McInnis wrote:

> Hi:
> 
> I really love Source-Navigator - especially the fact that we can extend
> its functionality in many ways without having to change the
> Source-Navigator source code.
> 
> Could you consider making more (or maybe even all?) of the methods and
> variables public rather than private?

No, we are not going to do that.

> Recently I needed to be able to access the value of text_current_line
> from the select_current_line method and found it necessary to override
> the whole Make class in order to get it. Seemed a shame to have to
> override 1000+ lines of code (which I'll then have/want  to keep in sync
> with redhat upgrades) when all I needed was to stick in one global
> statement...

It sounds like you need a method that will report information about
the currently selected line. That way you can get the data you
need without having to extend the class to do it. Why don't you
spec out what kind of info you need, write a method to provide
that info, and then post a patch implementing that change to
the Make and Grep classes?

cheers
Mo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-07-05 18:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-07-04 19:11 private variables, methods, etc Celia McInnis
2001-07-05 18:09 ` Mo DeJong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).