public inbox for src-cvs@sourceware.org help / color / mirror / Atom feed
From: tromey@sourceware.org To: src-cvs@sourceware.org Subject: gdb and binutils branch master updated. 52554a0e324951b5c58e71f2815e841377e9c50c Date: Fri, 08 Nov 2013 16:39:00 -0000 [thread overview] Message-ID: <20131108163934.10770.qmail@sourceware.org> (raw) This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "gdb and binutils". The branch, master has been updated via 52554a0e324951b5c58e71f2815e841377e9c50c (commit) from 79600f4f1bd97003233076f7b07ba2ced21a0c38 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=52554a0e324951b5c58e71f2815e841377e9c50c commit 52554a0e324951b5c58e71f2815e841377e9c50c Author: Tom Tromey <tromey@redhat.com> Date: Tue Mar 19 09:23:17 2013 -0600 constify to_detach This patch constifies the target_ops method to_detach. This is a small cleanup, but also, I think, a bug-prevention fix, since gdb already acts as if the "args" argument here was const. In particular, top.c:quit_force calls kill_or_detach via iterate_over_inferiors. kill_or_detach calls target_detach, passing the same argument each time. So, if one of these methods was not const-correct, then kill_or_detach would change its behavior in a strange way. I could not build every target I modified in this patch. I've inspected them all by hand, though. Many targets do not use the "args" parameter; a couple pass it to atoi; and a few pass it on to the to_detach method of the target beneath. The only code that required a real change was in linux-nat.c, and that only needed the introduction of a temporary variable for const-correctness. 2013-11-08 Tom Tromey <tromey@redhat.com> * aix-thread.c (aix_thread_detach): Update. * corelow.c (core_detach): Update. * darwin-nat.c (darwin_detach): Update. * dec-thread.c (dec_thread_detach): Update. * gnu-nat.c (gnu_detach): Update. * go32-nat.c (go32_detach): Update. * inf-ptrace.c (inf_ptrace_detach): Update. * inf-ttrace.c (inf_ttrace_detach): Update. * linux-fork.c (linux_fork_detach): Update. * linux-fork.h (linux_fork_detach): Update. * linux-nat.c (linux_nat_detach): Update. Introduce "tem" local for const-correctness. * linux-thread-db.c (thread_db_detach): Update. * monitor.c (monitor_detach): Update. * nto-procfs.c (procfs_detach): Update. * procfs.c (procfs_detach): Update. * record.c (record_detach): Update. * record.h (record_detach): Update. * remote-m32r-sdi.c (m32r_detach): Update. * remote-mips.c (mips_detach): Update. * remote-sim.c (gdbsim_detach): Update. * remote.c (remote_detach_1, remote_detach) (extended_remote_detach): Update. * sol-thread.c (sol_thread_detach): Update. * target.c (target_detach): Make "args" const. (init_dummy_target): Update. * target.h (struct target_ops) <to_detach>: Make argument const. (target_detach): Likewise. * windows-nat.c (windows_detach): Update. ----------------------------------------------------------------------- Summary of changes: gdb/ChangeLog | 32 ++++++++++++++++++++++++++++++++ gdb/aix-thread.c | 2 +- gdb/corelow.c | 4 +--- gdb/darwin-nat.c | 2 +- gdb/dec-thread.c | 2 +- gdb/gnu-nat.c | 2 +- gdb/go32-nat.c | 2 +- gdb/inf-ptrace.c | 2 +- gdb/inf-ttrace.c | 2 +- gdb/linux-fork.c | 2 +- gdb/linux-fork.h | 2 +- gdb/linux-nat.c | 9 ++++++--- gdb/linux-thread-db.c | 2 +- gdb/monitor.c | 2 +- gdb/nto-procfs.c | 2 +- gdb/procfs.c | 4 ++-- gdb/record.c | 2 +- gdb/record.h | 2 +- gdb/remote-m32r-sdi.c | 2 +- gdb/remote-mips.c | 4 +--- gdb/remote-sim.c | 2 +- gdb/remote.c | 8 +++----- gdb/sol-thread.c | 2 +- gdb/target.c | 4 ++-- gdb/target.h | 4 ++-- gdb/windows-nat.c | 2 +- 26 files changed, 67 insertions(+), 38 deletions(-) hooks/post-receive -- gdb and binutils
reply other threads:[~2013-11-08 16:39 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20131108163934.10770.qmail@sourceware.org \ --to=tromey@sourceware.org \ --cc=src-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).