[Bug kprobes/3310] New: kallsyms_lookup_name gone - update kprobes tests

[Bug kprobes/3310] New: kallsyms_lookup_name gone - update kprobes tests

[jkenisto at us dot ibm dot com]

In Linux 2.6.19-rc1, register_kprobe() has been enhanced so that you can set
kp.symbol_name and kp.offset as an alternative to setting kp.addr.  This
enhancement affects register_kretprobe() and register_jprobe() accordingly. 
Also, a new macro, regs_return_value(regs), is provided to extract the return
value from regs in a kretprobe handler.

A side effect of these enhancement is that kallsyms_lookup_name() is no longer
exported, and so existing kprobes-based modules that use kallsyms_lookup_name()
will break.  Consequently, test modules in tests/kernel need to be updated to
check "#ifdef regs_return_value" and set symbol_name+offset or
addr=kallsyms_lookup_name() accordingly.  Also to use regs_return_value().

Compare the example programs in Documentation/kprobes.txt in 2.6.19-rc1 with the
earlier versions for guidance.

-- 
           Summary: kallsyms_lookup_name gone - update kprobes tests
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P1
         Component: kprobes
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: jkenisto at us dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=3310

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug kprobes/3310] kallsyms_lookup_name gone - update kprobes tests

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2006-10-06 05:21 -------
IMO the better condition for the #ifdef is kprobe_lookup_name. The patch that
introduced this ifdef is the one that removed the kallsyms_lookup_name EXPORT.

And yes, the other change (enhancement) is to use the regs_return_value()

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3310

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug kprobes/3310] kallsyms_lookup_name gone - update kprobes tests

[jkenisto at us dot ibm dot com]

------- Additional Comments From jkenisto at us dot ibm dot com  2006-11-30 22:01 -------
Amit is working on this.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |amitc at linux dot vnet dot
                   |redhat dot com              |ibm dot com
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=3310

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.