[Bug tapsets/3833] New: nfs_proc.stp and LKET/nfs_proc.stp tapset files broken

[Bug tapsets/3833] New: nfs_proc.stp and LKET/nfs_proc.stp tapset files broken

[mmlnx at us dot ibm dot com]

During testing on SLES 10 we found numerous failures in the nfs_proc.stp and
LKET/nfs_proc.stp tapset files.  They appear to be the result of conditionals
like this from nfs_proc.stp:

    733 probe nfs.proc2.read_done = kernel.function("nfs_read_done")?,
    734                             module("nfs").function("nfs_read_done")?
    735 {
    736 %( kernel_v >= "2.6.10" %?
    737         server_ip = __nfs_read_data_info($data,0)
    738         prot = __nfs_read_data_info($data,1)
    739         count = __nfs_read_data_info($data, 2)
    740 %:
    741         server_ip = __nfs_read_data_info($task->tk_calldata,0)
    742         prot = __nfs_read_data_info($task->tk_calldata,1)
    743         count = __nfs_read_data_info($task->tk_calldata, 2)
    744 %)

The code assumes the "data" parameter appears in nfs_read_done() as of 2.6.10,
but a scan of previous major releases shows that "data" isn't a parameter until
2.6.17.

Other errors are probably the result of similar assumptions.  Someone needs to
go through these files and fix the conditionals to work on all versions.

-- 
           Summary: nfs_proc.stp and LKET/nfs_proc.stp tapset files broken
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: mmlnx at us dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=3833

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/3833] nfs_proc.stp and LKET/nfs_proc.stp tapset files broken

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-05-23 14:27 -------
There's an additional issue: module(nfs)->module(nfsd) and corresponding
renamed functions at some point between 2.6.18 and 2.6.24.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3833

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/3833] nfs_proc.stp and LKET/nfs_proc.stp tapset files broken

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-04-20 18:22 -------
Fixed in commit 93a7a5b by removing all kernel version checks in nfs_proc.stp,
using '@defined()' instead.  (LKET has been removed, so LKET/nfs_proc.stp is a
non-issue.)

Frank mentioned in comment #2 that some functions have been moved to nfsd. 
These are now handled in nfsd.stp.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=3833

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/3833] nfs_proc.stp and LKET/nfs_proc.stp tapset files broken

[dsmith at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=3833

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.