[Bug tapsets/6563] New: sys.stp fails on latest systemtap-20080524 snapshot

[Bug tapsets/6563] New: sys.stp fails on latest systemtap-20080524 snapshot

[srinivasa at in dot ibm dot com]

sys.stp fails on latest systemtap-20080524 snapshot with the below error.
===========================
/tmp/stapEM6Sec/stap_3fab86101321588190ddfafe8dcb7053_404801.c: In function
'function__stp_arg':
/tmp/stapEM6Sec/stap_3fab86101321588190ddfafe8dcb7053_404801.c:24204: error:
implicit declaration of function 'u_register'
/tmp/stapEM6Sec/stap_3fab86101321588190ddfafe8dcb7053_404801.c:24232: error:
implicit declaration of function '_stp_sign_extend32'
============================

Reason for the failure is,

In tapset/ppc64/register.stp, _stp_arg being an embedded "C" function calls
u_register(), which is not defined in kernel but in the same tapset script.

so we should avoid calling locally defined functions in embedded "c" functions. 
====================

function _stp_arg:long (argnum:long, sign_extend:long, truncate:long) %{
        long val;
        int n;
        size_t argsz = sizeof(long);

        THIS->__retvalue = 0;
        if (!CONTEXT->regs) {
                snprintf(CONTEXT->error_buffer, sizeof(CONTEXT->error_buffer),
                        "cannot access function args in this context");
                CONTEXT->last_error = CONTEXT->error_buffer;
                return;
        }
        if (THIS->argnum < 1)
                goto bad_argnum;
        n = (int) THIS->argnum;

        switch (n) {
        case 1:
                val = u_register("r3");
                break;

===================================

-- 
           Summary: sys.stp fails on latest systemtap-20080524 snapshot
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: srinivasa at in dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=6563

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/6563] sys.stp fails on latest systemtap-20080524 snapshot

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-05-26 15:21 -------
I don't see a good reason for _stp_arg to be an embedded-c function,
or really a lot of reason for it to exist at all.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6563

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/6563] sys.stp fails on latest systemtap-20080524 snapshot

[ananth at in dot ibm dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=6563

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/6563] sys.stp fails on latest systemtap-20080524 snapshot

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-05-28 09:04 -------
Sorry, this was a thinko from my side... patch forthcoming...

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |ananth at in dot ibm dot com
                   |redhat dot com              |


http://sourceware.org/bugzilla/show_bug.cgi?id=6563

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.