[Bug runtime/6923] New: STAPCONF_ONEACHCPU_RETRY test broken?

[Bug runtime/6923] New: STAPCONF_ONEACHCPU_RETRY test broken?

[jkenisto at us dot ibm dot com]

This has been failing for me for weeks; I keep hacking runtime/time.c to work
around it.  I think the problem is with runtime/autoconf-oneachcpu-retry.c.

When I get new SystemTap bits and run them on a 2.6.24 kernel (where
on_each_cpu() takes 4 args), the build of the stap-generated module fails due to
on_each_cpu() getting passed the wrong number of args.  Apparently,
STAPCONF_ONEACHCPU_RETRY is not getting defined in the build.

I think the problem is that the compile of autoconf-oneachcpu-retry.c always
fails, independently of how many args you pass to on_each_cpu().  On 2.6.24, at
least, you need to add #includes of <linux/stddef.h> and <linux/irqflags.h>, and
you need to pass an actual function as the first arg to on_each_cpu().

Watch this space for a proposed fix.

-- 
           Summary: STAPCONF_ONEACHCPU_RETRY test broken?
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: jkenisto at us dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=6923

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6923] STAPCONF_ONEACHCPU_RETRY test broken?

[jkenisto at us dot ibm dot com]

------- Additional Comments From jkenisto at us dot ibm dot com  2008-09-29 20:56 -------
Created an attachment (id=2969)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2969&action=view)
Suggested replacement for runtime/autoconf-oneachcpu-retry.c

As desired, the attached C file compiles cleanly on 2.6.24, but not on 2.6.27
(due to arg-list mismatch on the call to on_each_cpu()).

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6923

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6923] STAPCONF_ONEACHCPU_RETRY test broken?

[jkenisto at us dot ibm dot com]

------- Additional Comments From jkenisto at us dot ibm dot com  2008-10-17 21:51 -------
Checked in the indicated fix: commit 52333a6.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=6923

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.