* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
@ 2009-02-03 6:21 ` wenji dot huang at oracle dot com
2009-02-03 14:07 ` wenji dot huang at oracle dot com
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: wenji dot huang at oracle dot com @ 2009-02-03 6:21 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2009-02-03 05:36 -------
Reproduced it using testsuite/systemtap.examples/general/para-callgraph.stp
$sudo stap -vv para-callgraph.stp 'kernel.function("*@fs/proc*.c")'
'kernel.function("sys_read")'
...
Pass 3: translated to C into
"/tmp/stapI6MOvi/stap_6d7c9a6d948642fb62a56ab0e7db8c2b_133065.c" in
1840usr/2400sys/4935real ms.
Running make -C "/lib/modules/2.6.29-rc3/build" M="/tmp/stapI6MOvi" modules
>/dev/null
cc1: warnings being treated as errors
/tmp/stapI6MOvi/stap_6d7c9a6d948642fb62a56ab0e7db8c2b_133065.c: In function
'probe_1422':
/tmp/stapI6MOvi/stap_6d7c9a6d948642fb62a56ab0e7db8c2b_133065.c:2569: warning:
's0' is used uninitialized in this function
make[1]: *** [/tmp/stapI6MOvi/stap_6d7c9a6d948642fb62a56ab0e7db8c2b_133065.o]
Error 1
make: *** [_module_/tmp/stapI6MOvi] Error 2
Pass 4: compiled C into "stap_6d7c9a6d948642fb62a56ab0e7db8c2b_133065.ko" in
17790usr/4530sys/22241real ms.
Pass 4: compilation failed. Try again with another '--vp 0001' option.
$ stap -V
SystemTap translator/driver (version 0.8/0.131 commit d1d11e96 + changes)
Copyright (C) 2005-2008 Red Hat, Inc. and others
This is free software; see the source for copying conditions.
$ gcc -v
Reading specs from /usr/lib/gcc/i386-redhat-linux/3.4.6/specs
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --enable-shared --enable-threads=posix
--disable-checking --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-java-awt=gtk --host=i386-redhat-linux
Thread model: posix
gcc version 3.4.6 20060404 (Red Hat 3.4.6-9.0.1)
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
2009-02-03 6:21 ` [Bug translator/6979] " wenji dot huang at oracle dot com
@ 2009-02-03 14:07 ` wenji dot huang at oracle dot com
2009-02-03 19:42 ` fche at redhat dot com
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: wenji dot huang at oracle dot com @ 2009-02-03 14:07 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2009-02-03 07:50 -------
Did some more tests. Seems it will happen on specific probe point combination
with $$parms. Such as,
stap -p4 -vve 'probe kernel.function("proc_reg_llseek"){printf("%s\n",$$parms)}'
But it can pass when executing
stap -p4 -vve 'probe kernel.function("proc_reg_llseek"){printf("%s\n",pp())}'
stap -p4 -vve 'probe kernel.function("proc_register"){printf("%s\n",$$parms)}'
The root cause is the generated incorrect code
{
intptr_t s0;
addr = s0;
}
It should be like,
{
intptr_t s0;
s0 = fetch_register (5) + -28L;
addr = s0;
}
Theses are from loc2c.c::emit_loc_address,
emit ("%s%*s%s = " STACKFMT ";\n", loc->address.program,
(indent + 1) * 2, "", target, 0);
In some cases, loc->address.program='\0' cause the error.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
2009-02-03 6:21 ` [Bug translator/6979] " wenji dot huang at oracle dot com
2009-02-03 14:07 ` wenji dot huang at oracle dot com
@ 2009-02-03 19:42 ` fche at redhat dot com
2009-02-04 3:11 ` wenji dot huang at oracle dot com
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fche at redhat dot com @ 2009-02-03 19:42 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2009-02-03 16:42 -------
This must depend on the compiler/architecture. Perhaps it's passing a type
that we haven't dealt with before on loc2c. Can you share the e.g. git binary
you had problem with?
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (2 preceding siblings ...)
2009-02-03 19:42 ` fche at redhat dot com
@ 2009-02-04 3:11 ` wenji dot huang at oracle dot com
2009-02-04 5:56 ` wenji dot huang at oracle dot com
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: wenji dot huang at oracle dot com @ 2009-02-04 3:11 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2009-02-04 02:17 -------
Created an attachment (id=3708)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=3708&action=view)
the generated stap_xxx.c, stap-symbols.h, Makefile.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (3 preceding siblings ...)
2009-02-04 3:11 ` wenji dot huang at oracle dot com
@ 2009-02-04 5:56 ` wenji dot huang at oracle dot com
2009-02-04 11:34 ` wenji dot huang at oracle dot com
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: wenji dot huang at oracle dot com @ 2009-02-04 5:56 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2009-02-04 02:56 -------
I added some print code to loc2c, before
237 switch (expr[i].atom)
238 {
found there was one kind of dwarf_location_atom happened, DW_OP_breg5 = 0x75
but not processed by loc2c. Maybe this will the culprit.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (4 preceding siblings ...)
2009-02-04 5:56 ` wenji dot huang at oracle dot com
@ 2009-02-04 11:34 ` wenji dot huang at oracle dot com
2009-02-04 17:08 ` fche at redhat dot com
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: wenji dot huang at oracle dot com @ 2009-02-04 11:34 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2009-02-04 03:10 -------
(In reply to comment #5)
> I added some print code to loc2c, before
> 237 switch (expr[i].atom)
> 238 {
> found there was one kind of dwarf_location_atom happened, DW_OP_breg5 = 0x75
> but not processed by loc2c. Maybe this will the culprit.
Sorry, DW_OP_breg5 is covered. Please ignore the comment.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (5 preceding siblings ...)
2009-02-04 11:34 ` wenji dot huang at oracle dot com
@ 2009-02-04 17:08 ` fche at redhat dot com
2009-02-05 14:55 ` wenji dot huang at oracle dot com
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fche at redhat dot com @ 2009-02-04 17:08 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2009-02-04 14:57 -------
Please make the ELF binary available somewhere.
Otherwise, you'd need to extract the debugging data dump (eu-readelf -w),
ideally narrowed down to the variable in question and its location list.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (6 preceding siblings ...)
2009-02-04 17:08 ` fche at redhat dot com
@ 2009-02-05 14:55 ` wenji dot huang at oracle dot com
2009-02-05 21:05 ` fche at redhat dot com
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: wenji dot huang at oracle dot com @ 2009-02-05 14:55 UTC (permalink / raw)
To: systemtap
------- Additional Comments From wenji dot huang at oracle dot com 2009-02-05 08:03 -------
Created an attachment (id=3720)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=3720&action=view)
debuginfo dump for the probe function, including info and loc.
Vmlinux is too big. I extracted the related info and location from debuginfo
file for the example function proc_reg_llseek
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (7 preceding siblings ...)
2009-02-05 14:55 ` wenji dot huang at oracle dot com
@ 2009-02-05 21:05 ` fche at redhat dot com
2009-02-20 14:24 ` fche at redhat dot com
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fche at redhat dot com @ 2009-02-05 21:05 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2009-02-05 20:59 -------
I haven't reproduced this problem, and we still don't have the entire
copy of *some* affected elf file. However, looking at the attachment
and the loc2c code, it seem the following combination is not being
handled by loc2c:
[ e93f3] 0xc0189445 <proc_reg_llseek>..0xc0189455 <proc_reg_llseek+0x10> [
0] reg2
[ 1] piece 4
[ 3] reg1
[ 4] piece 4
To wit, the reg1 piece.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |roland at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (8 preceding siblings ...)
2009-02-05 21:05 ` fche at redhat dot com
@ 2009-02-20 14:24 ` fche at redhat dot com
2009-06-11 12:31 ` srikar at linux dot vnet dot ibm dot com
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fche at redhat dot com @ 2009-02-20 14:24 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2009-02-20 12:43 -------
> Vmlinux is too big.
Then please post or send somewhere your git binary that showed the same problem.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (9 preceding siblings ...)
2009-02-20 14:24 ` fche at redhat dot com
@ 2009-06-11 12:31 ` srikar at linux dot vnet dot ibm dot com
2009-11-11 14:35 ` fche at redhat dot com
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: srikar at linux dot vnet dot ibm dot com @ 2009-06-11 12:31 UTC (permalink / raw)
To: systemtap
------- Additional Comments From srikar at linux dot vnet dot ibm dot com 2009-06-11 12:30 -------
Sorry for the delayed response.
I have verified that the problem reported is still reproducible with systemtap
snapshot for the week starting 8th June 2009.
I have placed a bzipped binary at
http://www.4shared.com/file/111179507/3598a80e/git.html
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (10 preceding siblings ...)
2009-06-11 12:31 ` srikar at linux dot vnet dot ibm dot com
@ 2009-11-11 14:35 ` fche at redhat dot com
2009-11-11 20:21 ` roland at gnu dot org
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fche at redhat dot com @ 2009-11-11 14:35 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2009-11-11 14:35 -------
Still reported as of systemtap 0.9.7
https://bugzilla.redhat.com/show_bug.cgi?id=536807
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (11 preceding siblings ...)
2009-11-11 14:35 ` fche at redhat dot com
@ 2009-11-11 20:21 ` roland at gnu dot org
2009-11-18 17:32 ` fche at redhat dot com
2009-11-18 18:29 ` [Bug translator/6979] loc2c code generation error, uninitialized variable access, mishandling of multiple-piece $target vars fche at redhat dot com
14 siblings, 0 replies; 16+ messages in thread
From: roland at gnu dot org @ 2009-11-11 20:21 UTC (permalink / raw)
To: systemtap
------- Additional Comments From roland at gnu dot org 2009-11-11 20:20 -------
commit 56cfcfc
Please check for other regressions.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] using $$parms under uprobe probes might result in a uninitialized variable access.
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (12 preceding siblings ...)
2009-11-11 20:21 ` roland at gnu dot org
@ 2009-11-18 17:32 ` fche at redhat dot com
2009-11-18 18:29 ` [Bug translator/6979] loc2c code generation error, uninitialized variable access, mishandling of multiple-piece $target vars fche at redhat dot com
14 siblings, 0 replies; 16+ messages in thread
From: fche at redhat dot com @ 2009-11-18 17:32 UTC (permalink / raw)
To: systemtap
------- Additional Comments From fche at redhat dot com 2009-11-18 17:32 -------
fixed
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug translator/6979] loc2c code generation error, uninitialized variable access, mishandling of multiple-piece $target vars
2008-10-24 8:23 [Bug translator/6979] New: using $$parms under uprobe probes might result in a uninitialized variable access srikar at linux dot vnet dot ibm dot com
` (13 preceding siblings ...)
2009-11-18 17:32 ` fche at redhat dot com
@ 2009-11-18 18:29 ` fche at redhat dot com
14 siblings, 0 replies; 16+ messages in thread
From: fche at redhat dot com @ 2009-11-18 18:29 UTC (permalink / raw)
To: systemtap
--
What |Removed |Added
----------------------------------------------------------------------------
Summary|using $$parms under uprobe |loc2c code generation error,
|probes might result in a |uninitialized variable
|uninitialized variable |access, mishandling of
|access. |multiple-piece $target vars
http://sourceware.org/bugzilla/show_bug.cgi?id=6979
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 16+ messages in thread