[Bug translator/10877] New: improve probe point error reporting

[Bug translator/10877] New: improve probe point error reporting

[fche at redhat dot com]

Currently we store just one tok* per probe_point, instead of one
per probe point element (the stuff around the dots).  This leads
to hard-to-interpret error messages

% stap -p2 -e 'probe kernel.junkction("sdf") {}'
semantic error: probe point mismatch at position 1 (alternatives:
function(number) function(string) mark(string) statement(number)
statement(string) trace(string)): identifier 'kernel' at <input>:1:7 while
resolving probe point kernel.junkction("sdf")
        source: probe kernel.junkction("sdf") {}
                      ^
Pass 2: analysis failed.  Try again with another '--vp 01' option.

Instead, we should store a tok* per probe point element, so that an
error can point the caret at just the right spot, and we can drop
the "at position N" from the error description body.

-- 
           Summary: improve probe point error reporting
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10877

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10877] improve probe point error reporting

[chwang at redhat dot com]

------- Additional Comments From chwang at redhat dot com  2009-11-02 17:03 -------
(In reply to comment #0)
> Currently we store just one tok* per probe_point, instead of one
> per probe point element (the stuff around the dots).  This leads
> to hard-to-interpret error messages
> 
> % stap -p2 -e 'probe kernel.junkction("sdf") {}'
> semantic error: probe point mismatch at position 1 (alternatives:
> function(number) function(string) mark(string) statement(number)
> statement(string) trace(string)): identifier 'kernel' at <input>:1:7 while
> resolving probe point kernel.junkction("sdf")
>         source: probe kernel.junkction("sdf") {}
>                       ^
> Pass 2: analysis failed.  Try again with another '--vp 01' option.
> 
> Instead, we should store a tok* per probe point element, so that an
> error can point the caret at just the right spot, and we can drop
> the "at position N" from the error description body.


To confirm, you are suggesting the use of:

>         source: probe kernel.junkction("sdf") {}
>                              ^

Yes?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10877

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/10877] improve probe point error reporting

[fche at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |10907
              nThis|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=10877

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.