public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat.com>
To: Wenji Huang <wenji.huang@oracle.com>
Cc: "systemtap@sourceware.org" <systemtap@sourceware.org>
Subject: Re: [RFC PATCH] Fix segmentation fault of listing kprocess.create
Date: Fri, 06 Nov 2009 11:19:00 -0000	[thread overview]
Message-ID: <20091106111939.GA7039@redhat.com> (raw)
In-Reply-To: <4AF37691.6000601@oracle.com>

Hi -

On Fri, Nov 06, 2009 at 09:06:25AM +0800, Wenji Huang wrote:
> [...]
> The empty token is from my patch for 10820, sorry for the
> error.  [...]

No problem.

> diff --git a/tapsets.cxx b/tapsets.cxx
> index d2c3334..17e315e 100644
> --- a/tapsets.cxx
> +++ b/tapsets.cxx
> @@ -2928,6 +2928,14 @@ dwarf_derived_probe::saveargs(dwarf_query& q, 
> Dwarf_Die* scope_die, dwarf_var_ex
>          /* trick from visit_target_symbol_context */
>          target_symbol *tsym = new target_symbol;
>          token *t = new token;
> +        /* We hypothesize accessing the argument
> +         * The source_loc will be base_loc since no real one  */
> +        t->content = "$";
> +        t->content += arg_name;
> +        t->type = tok_identifier;
> +        t->location.file = q.base_loc->tok->location.file;
> +        t->location.column = q.base_loc->tok->location.column;
> +        t->location.line = q.base_loc->tok->location.line;
>          tsym->tok = t;

You shouldn't need to synthesize this either really.  Just copy the
pointer from q.base_loc->tok, if we don't have a vardecl or expression
handy.

- FChE

  reply	other threads:[~2009-11-06 11:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  5:03 Wenji Huang
2009-11-05  7:00 ` Wenji Huang
2009-11-05  7:36   ` Wenji Huang
2009-11-05 14:12     ` Frank Ch. Eigler
2009-11-06  1:08       ` Wenji Huang
2009-11-06 11:19         ` Frank Ch. Eigler [this message]
2009-11-07  0:14     ` Josh Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091106111939.GA7039@redhat.com \
    --to=fche@redhat.com \
    --cc=systemtap@sourceware.org \
    --cc=wenji.huang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).