From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
Roland McGrath <roland@redhat.com>,
Jason Baron <jbaron@redhat.com>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [PATCH -tip v3 0/3] tracepoint: Add signal events
Date: Tue, 24 Nov 2009 21:28:00 -0000 [thread overview]
Message-ID: <20091124212247.GA11773@redhat.com> (raw)
In-Reply-To: <20091123175740.GA15594@elte.hu>
On 11/23, Ingo Molnar wrote:
>
> * Masami Hiramatsu <mhiramat@redhat.com> wrote:
>
> > Hi,
> >
> > These patches add signal related tracepoints including
> > signal generation, delivery, and loss. First patch also
> > moves signal-sending tracepoint from events/sched.h to
> > events/signal.h.
> >
> > Changes in v3
> > - Add Docbook style comments
> >
> > Changes in v2
> > - Add siginfo arguments
> >
> > Thank you,
> >
> > ---
> >
> > Masami Hiramatsu (3):
> > tracepoint: Add signal loss events
> > tracepoint: Add signal deliver event
> > tracepoint: Move signal sending tracepoint to events/signal.h
> >
> >
> > Documentation/DocBook/tracepoint.tmpl | 5 +
> > include/trace/events/sched.h | 25 -----
> > include/trace/events/signal.h | 173 +++++++++++++++++++++++++++++++++
> > kernel/signal.c | 27 ++++-
> > 4 files changed, 198 insertions(+), 32 deletions(-)
> > create mode 100644 include/trace/events/signal.h
>
> Would be nice to have Roland's and Oleg's Acked-by tags in the patches -
> to show that this is a representative and useful looking set of signal
> events.
Sorry, I can't really comment these patches.
I mean, I do not know which info is useful and which is not.
For example, I am a bit surprized we report trace_signal_lose_info()
but please do not consider this as if I think we shouldn't. Just I
do not know.
OTOH, we do not report if __send_signal() fails just because the
legacy signal is already queued. We do not report who sends the signal,
we do not report if it was private or shared. zap_process, complete_signal
can "send" SIGKILL via sigaddset, this won't be noticed. But again, it is
not that I think this should be reported.
In short: I think any info may be useful, and these patches can help.
But I do not understand what exactly should be reported to userspace.
Oleg.
next prev parent reply other threads:[~2009-11-24 21:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 21:29 Masami Hiramatsu
2009-11-20 21:29 ` [PATCH -tip v3 2/3] tracepoint: Add signal deliver event Masami Hiramatsu
2009-11-20 21:29 ` [PATCH -tip v3 1/3] tracepoint: Move signal sending tracepoint to events/signal.h Masami Hiramatsu
2009-11-24 20:55 ` Oleg Nesterov
2009-11-24 21:00 ` Masami Hiramatsu
2009-11-20 21:30 ` [PATCH -tip v3 3/3] tracepoint: Add signal loss events Masami Hiramatsu
2009-11-23 17:59 ` [PATCH -tip v3 0/3] tracepoint: Add signal events Ingo Molnar
2009-11-24 21:28 ` Oleg Nesterov [this message]
2009-11-24 21:45 ` Masami Hiramatsu
2009-11-24 21:56 ` Ingo Molnar
2009-11-25 17:46 ` Oleg Nesterov
2009-11-23 23:01 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124212247.GA11773@redhat.com \
--to=oleg@redhat.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).