[Bug tapsets/9871] New: use @cast() instead of embedded-c whereever possible

[Bug tapsets/9871] New: use @cast() instead of embedded-c whereever possible

[fche at redhat dot com]

Now that we have it, let's use it.

-- 
           Summary: use @cast() instead of embedded-c whereever possible
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: fche at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-02-27 14:46 -------
I did one small rewrite of tapset/inet_sock.stp, which is nicely smaller now. It
does still need a small tidbit of embedded C because we cannot easily cast
between basic types/unions, see the new daddr_to_string.

function inet_get_local_port:long(sock:long)
{
%(kernel_v < "2.6.21" %?
  port = @cast(sock, "inet_sock", "kernel")->inet->num;
%:
  port = @cast(sock, "inet_sock", "kernel")->num;
%)
  return port;
}

// Get IP source address string given a pointer to a kernel socket.
function inet_get_ip_source:string(sock:long)
{
%(kernel_v < "2.6.21" %?
  daddr = @cast(sock, "inet_sock", "kernel")->inet->daddr;
%:
  daddr = @cast(sock, "inet_sock", "kernel")->daddr;
%)
  return daddr_to_string(daddr);
}

// Turns a daddr as found in an inet_sock into a dotted ip string.
function daddr_to_string:string(daddr:long)
%{ /* pure */
	union { __u32 d; unsigned char addr[4]; } u;
	u.d = THIS->daddr;
	sprintf(THIS->__retvalue, "%d.%d.%d.%d",
			u.addr[0], u.addr[1], u.addr[2], u.addr[3]);
%}

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-03-05 08:05 -------
Created an attachment (id=3794)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3794&action=view)
Revamp some functions of nfs.stp using @cast 

The new functions look more compact and many duplicated codes have been
eliminated.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2009-03-05 12:12 -------
Yes much nicer and much more readable compared to the previous versions. Thanks.

One minor stylistic request. Could you add spaces around the ? and : so that
something like:

dentry = file? @cast(file, "file", "kernel")->f_dentry: 0

will look like:

dentry = file ? @cast(file, "file", "kernel")->f_dentry : 0

that makes them a bit more readable and makes the sources a bit more consistent
(currently the sources sometimes do and sometimes don't add spaces).

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2009-03-06 09:48 -------
thanks for your review. More update see commit
fb3b52a7346202fea1905ed680a3256d372a7b03 PR9871: use @cast in tapset 


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[fche at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |9932


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[jkenisto at us dot ibm dot com]

------- Additional Comments From jkenisto at us dot ibm dot com  2009-03-09 20:09 -------
In taspset/*/registers.stp, _stp_get_register_by_offset() could be replaced
using @cast.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2009-03-09 20:38 -------
(In reply to comment #5)
> In taspset/*/registers.stp, _stp_get_register_by_offset() could be replaced
> using @cast.

Just remember that @cast requires debuginfo -- aren't the registers tapsets
designed to be helpful for running with no debuginfo?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[jkenisto at us dot ibm dot com]

------- Additional Comments From jkenisto at us dot ibm dot com  2009-03-09 21:06 -------
Correct.  (In reply to comment #6)
> (In reply to comment #5)
> > In taspset/*/registers.stp, _stp_get_register_by_offset() could be replaced
> > using @cast.
> 
> Just remember that @cast requires debuginfo -- aren't the registers tapsets
> designed to be helpful for running with no debuginfo?

Yes, indeed.  Does it help that we'd be casting only to predefined types --
e.g., pointer-to-long?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2009-03-09 22:27 -------
(In reply to comment #7)
> Yes, indeed.  Does it help that we'd be casting only to predefined types --
> e.g., pointer-to-long?

For POD types, you can just use kernel_long() and family.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[jistone at redhat dot com]

-- 
Bug 9871 depends on bug 9932, which changed state.

Bug 9932 Summary: @cast module search path
http://sourceware.org/bugzilla/show_bug.cgi?id=9932

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[nuhn at physik dot rwth-aachen dot de]

------- Additional Comments From nuhn at physik dot rwth-aachen dot de  2009-04-29 16:37 -------
I have some problems with the 0.9.7 Version of Systemtap.
Scripts than run with 0.9 don't run anymore on 0.9.7.

I think it affects the "@cast" stuff, in my example this affects "inet_sock.stp"

Changing:
daddr = @cast(sock, "inet_sock", "kernel")->inet->daddr;

To:
daddr = @cast(sock, "inet_sock", "kernel<linux/ip.h>")->inet->daddr;

Fixes the problem.

I have a 2.6.9 Kernel.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-03-26 18:26 -------
Commit 961479c removes some embedded-C from tcpmib.stp

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-03-30 20:57 -------
Commit 1713a05 removed some embedded-C in ioblock.stp/vfs.stp

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-04-05 17:30 -------
Commit fd81a55 removed some embedded-C from nfs_proc.stp.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-04-05 19:56 -------
Commit abf0244 removed more embedded-C from nfs_proc.stp.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-04-06 15:05 -------
Commit 84b869b removed more embedded-C in nfs_proc.stp and nfs.stp.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-04-06 16:37 -------
Commit dd3d6ed removed some embedded-C from scsi.stp.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-04-07 14:44 -------
Commit 7dfee5e removes all embedded-C in rpc.stp.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-04-07 21:14 -------
Commit 354c797 removed some embedded-C in ioblock.stp and ipmib.stp.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Re: [Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[Steve Dickson]

Hello,

On 04/07/2010 10:44 AM, dsmith at redhat dot com wrote:
> ------- Additional Comments From dsmith at redhat dot com  2010-04-07 14:44 -------
> Commit 7dfee5e removes all embedded-C in rpc.stp.
> 
About this commit... It seems to have broken the rpc.stp probe
on a 2.6.32 kernel... I'm currently in the process of fixing things, 
but I've run across an compilation error that has me stumped.

The compile error is:
stap_22691.c:5944: error: 'union <anonymous>' has no member named 'function_vers_from_prog'

The C code line in questions is:
c->locals[c->nesting+1].function_vers_from_prog.program = l->__tmp12;

The function looks like:

function vers_from_prog:long(program:long, vers:long)
{
    if (program
    && vers < @cast(program, "rpc_program", "kernel:sunrpc")->nrvers)
        return 0
    return @cast(program, "rpc_program", "kernel:sunrpc")->version[vers]->number
}

The systemtap version is 1.2-1

any ideas? 

steved.

Re: [Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[David Smith]

Here's an update on this for the list.  From talking to Steve on irc,
after cleaning out his cache, this stopped happening.

On 04/12/2010 07:47 AM, Steve Dickson wrote:
> Hello,
> 
> On 04/07/2010 10:44 AM, dsmith at redhat dot com wrote:
>> ------- Additional Comments From dsmith at redhat dot com  2010-04-07 14:44 -------
>> Commit 7dfee5e removes all embedded-C in rpc.stp.
>>
> About this commit... It seems to have broken the rpc.stp probe
> on a 2.6.32 kernel... I'm currently in the process of fixing things, 
> but I've run across an compilation error that has me stumped.
> 
> The compile error is:
> stap_22691.c:5944: error: 'union <anonymous>' has no member named 'function_vers_from_prog'
> 
> The C code line in questions is:
> c->locals[c->nesting+1].function_vers_from_prog.program = l->__tmp12;
> 
> The function looks like:
> 
> function vers_from_prog:long(program:long, vers:long)
> {
>     if (program
>     && vers < @cast(program, "rpc_program", "kernel:sunrpc")->nrvers)
>         return 0
>     return @cast(program, "rpc_program", "kernel:sunrpc")->version[vers]->number
> }
> 
> The systemtap version is 1.2-1
> 
> any ideas? 
> 
> steved.


-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-05-11 18:00 -------
Commit 5ccccbb removed all remaining embedded-C from vfs.stp.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-05-12 17:51 -------
Commit 00bd540 removed some embedded-C from task.stp and context.stp.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible

[dsmith at redhat dot com]

------- Additional Comments From dsmith at redhat dot com  2010-09-27 14:45 -------
I've made a pass through the tapsets and removed embedded-C when feasible.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=9871

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.