[Bug translator/11858] New: Confusing error message with get_kretprobe_long

[Bug translator/11858] New: Confusing error message with get_kretprobe_long

[mjw at redhat dot com]

The following is a bit of a weird way to tell me $filename is a pointer to a string:

$ stap -e 'probe syscall.open.return { log("opened: " . $filename); }'
semantic error: type mismatch (long vs. string): identifier
'_get_kretprobe_long' at
/usr/local/install/systemtap/share/systemtap/tapset/kretprobe.stp:30:10
        source: function _get_kretprobe_long:long(i:long) %{ /* pure */
                         ^
Pass 2: analysis failed.  Try again with another '--vp 01' option.

Obviously I should have used user_string($filename) here. It is harder to spot
what the real error is in a larger return probe handler which has multiple
string contexts.

-- 
           Summary: Confusing error message with get_kretprobe_long
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: mjw at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=11858

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11858] Confusing error message with get_kretprobe_long

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2010-07-30 13:18 -------
Is this a duplicate of bug #11504?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11858

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11858] Confusing error message with get_kretprobe_long

[jistone at redhat dot com]

------- Additional Comments From jistone at redhat dot com  2010-07-30 16:26 -------
This isn't the fault of kretprobe-saving in particular, e.g.

$ stap -e 'probe syscall.open.return { log("pid: " . pid()); }'
semantic error: type mismatch (long vs. string): identifier 'pid' at
/usr/share/systemtap/tapset/context.stp:48:10
        source: function pid:long ()
                         ^
Pass 2: analysis failed.  Try again with another '--vp 01' option.

We ought to identify the *caller* as the type mismatch, not the callee.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11858

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug translator/11858] Confusing error message with get_kretprobe_long

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=11858

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |fche at redhat dot com
         Resolution|---                         |WORKSFORME

--- Comment #3 from Frank Ch. Eigler <fche at redhat dot com> ---
The current error message is pretty good:

% stap -e 'probe syscall.open.return { log("pid: " . pid()); }'
semantic error: type mismatch: expected string but found long: identifier 'pid'
at <input>:1:43
        source: probe syscall.open.return { log("pid: " . pid()); }
                                                          ^

-- 
You are receiving this mail because:
You are the assignee for the bug.