public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Adrien Kunysz <adrien@kunysz.be>
Cc: Josh Stone <jistone@redhat.com>,
	contemplating zombie <contemplatingzombie@gmail.com>,
	systemtap@sourceware.org
Subject: Re: Puzzling output of stp script
Date: Sun, 25 Dec 2011 23:59:00 -0000	[thread overview]
Message-ID: <20111225202026.GB3980@toonder.wildebeest.org> (raw)
In-Reply-To: <20111225110952.GD17069@chouffe>

On Sun, Dec 25, 2011 at 11:09:52AM +0000, Adrien Kunysz wrote:
> And that particular example was already fixed a while ago btw:
> http://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commitdiff;h=396afcee5ada2d207b7a6691d4b7ce473e7b2a65

But it was still used in at least two places, the tutorial and beginner's
guide, without the .call modifier. Fixed those too and added Josh's
suggestion as an exercise:

commit 2e96e9163d84fe9772def0318216a6d6da1332a2
Author: Mark Wielaard <mjw@redhat.com>
Date:   Sun Dec 25 20:56:53 2011 +0100

  Use function.call and function.return in all thread_indent() examples.
    
  If the .call modifier isn't used the function probes will match both .call
  and .inline, but .return doesn't match any inlined functions leading to
  unbalanced thread_indent output.

Cheers,

Mark

      reply	other threads:[~2011-12-25 20:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAO_gTC6yXVN-6a-aj6YFy4Z_7wGaMRzbHTWWWdQOyWgD=g0rOQ@mail.gmail.com>
2011-12-24 19:14 ` contemplating zombie
2011-12-24 22:56   ` Adrien Kunysz
2011-12-25  5:56     ` contemplating zombie
2011-12-25 11:07   ` Josh Stone
2011-12-25 20:20     ` Adrien Kunysz
2011-12-25 23:59       ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111225202026.GB3980@toonder.wildebeest.org \
    --to=mark@klomp.org \
    --cc=adrien@kunysz.be \
    --cc=contemplatingzombie@gmail.com \
    --cc=jistone@redhat.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).