public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Use NEWS file date instead of build date
@ 2017-11-24 15:01 Bernhard M. Wiedemann
  2017-11-27 15:57 ` David Smith
  0 siblings, 1 reply; 6+ messages in thread
From: Bernhard M. Wiedemann @ 2017-11-24 15:01 UTC (permalink / raw)
  To: systemtap; +Cc: Bernhard M. Wiedemann

as date in man page headers, in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.

Also use UTC to be independent of timezone

---
While working on making openSUSE Linux package builds reproducible,
I found that the systemtap package would differ in the stappaths.7
man page

An alternative solution could use $SOURCE_DATE_EPOCH
to allow to override the date but leave the default behaviour as before.
But I think few people care about which date goes into the manual.
---
 configure    | 2 +-
 configure.ac | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 099664f..1f0b64d 100755
--- a/configure
+++ b/configure
@@ -11451,7 +11451,7 @@ $as_echo "$as_me: staprun will link $staprun_LIBS" >&6;}
 $as_echo "$as_me: stapbpf will link $stapbpf_LIBS" >&6;}
 
 
-date=`date +%Y-%m-%d`
+date=`date -u -r NEWS +%Y-%m-%d`
 
 cat >>confdefs.h <<_ACEOF
 #define DATE "$date"
diff --git a/configure.ac b/configure.ac
index a5cb47c..a10fd83 100644
--- a/configure.ac
+++ b/configure.ac
@@ -598,7 +598,7 @@ AC_MSG_NOTICE([stapbpf will link $stapbpf_LIBS])
 
 
 dnl Plop in the build (configure) date
-date=`date +%Y-%m-%d`
+date=`date -u -r NEWS +%Y-%m-%d`
 AC_DEFINE_UNQUOTED(DATE, "$date", [Configuration/build date])
 AC_SUBST(DATE, "$date")
 
-- 
2.13.6

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Use NEWS file date instead of build date
  2017-11-24 15:01 [PATCH] Use NEWS file date instead of build date Bernhard M. Wiedemann
@ 2017-11-27 15:57 ` David Smith
  2017-11-28  8:59   ` [PATCH] Do not add build date into man pages Bernhard M. Wiedemann
  2017-12-05 18:34   ` [PATCH] Use NEWS file date instead of build date David Smith
  0 siblings, 2 replies; 6+ messages in thread
From: David Smith @ 2017-11-27 15:57 UTC (permalink / raw)
  To: Bernhard M. Wiedemann; +Cc: systemtap

Hmm. I wonder if it wouldn't make more sense just to remove the DATE
stuff from configure.ac and stappaths.7.in. I'm not sure it adds much
value. For reference sake, here's the one and only place where DATE is
used. This is in stappaths.7.in:

This manual page was generated on @DATE@ for systemtap @VERSION@.

On Fri, Nov 24, 2017 at 9:00 AM, Bernhard M. Wiedemann
<bwiedemann@suse.de> wrote:
> as date in man page headers, in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good.
>
> Also use UTC to be independent of timezone
>
> ---
> While working on making openSUSE Linux package builds reproducible,
> I found that the systemtap package would differ in the stappaths.7
> man page
>
> An alternative solution could use $SOURCE_DATE_EPOCH
> to allow to override the date but leave the default behaviour as before.
> But I think few people care about which date goes into the manual.
> ---
>  configure    | 2 +-
>  configure.ac | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 099664f..1f0b64d 100755
> --- a/configure
> +++ b/configure
> @@ -11451,7 +11451,7 @@ $as_echo "$as_me: staprun will link $staprun_LIBS" >&6;}
>  $as_echo "$as_me: stapbpf will link $stapbpf_LIBS" >&6;}
>
>
> -date=`date +%Y-%m-%d`
> +date=`date -u -r NEWS +%Y-%m-%d`
>
>  cat >>confdefs.h <<_ACEOF
>  #define DATE "$date"
> diff --git a/configure.ac b/configure.ac
> index a5cb47c..a10fd83 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -598,7 +598,7 @@ AC_MSG_NOTICE([stapbpf will link $stapbpf_LIBS])
>
>
>  dnl Plop in the build (configure) date
> -date=`date +%Y-%m-%d`
> +date=`date -u -r NEWS +%Y-%m-%d`
>  AC_DEFINE_UNQUOTED(DATE, "$date", [Configuration/build date])
>  AC_SUBST(DATE, "$date")
>
> --
> 2.13.6
>



-- 
David Smith
Principal Software Engineer
Red Hat

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] Do not add build date into man pages
  2017-11-27 15:57 ` David Smith
@ 2017-11-28  8:59   ` Bernhard M. Wiedemann
  2017-12-05 18:34   ` [PATCH] Use NEWS file date instead of build date David Smith
  1 sibling, 0 replies; 6+ messages in thread
From: Bernhard M. Wiedemann @ 2017-11-28  8:59 UTC (permalink / raw)
  To: systemtap; +Cc: Bernhard M. Wiedemann

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.
---
 man/cs/stappaths.7.in | 2 +-
 man/stappaths.7.in    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/man/cs/stappaths.7.in b/man/cs/stappaths.7.in
index 416393d..eb8ca76 100644
--- a/man/cs/stappaths.7.in
+++ b/man/cs/stappaths.7.in
@@ -18,7 +18,7 @@ stappaths \- důležitá umístění souborů a adresářů systemtapu
 ..
 
 .SH POPIS
-Tato manuálová stránka byla vygenerována @DATE@ pro systemtap @VERSION@.
+Tato manuálová stránka byla vygenerována pro systemtap @VERSION@.
 Následuje seznam důležitých umístění souborů a adresářů.
 
 .TP
diff --git a/man/stappaths.7.in b/man/stappaths.7.in
index 2b469f2..7382444 100644
--- a/man/stappaths.7.in
+++ b/man/stappaths.7.in
@@ -18,7 +18,7 @@ stappaths \- systemtap configurable file paths
 ..
 
 .SH DESCRIPTION
-This manual page was generated on @DATE@ for systemtap @VERSION@.
+This manual page was generated for systemtap @VERSION@.
 The following section will list the main paths in systemtap that are 
 important to know and may be required to reference.
 .TP
-- 
2.13.6

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Use NEWS file date instead of build date
  2017-11-27 15:57 ` David Smith
  2017-11-28  8:59   ` [PATCH] Do not add build date into man pages Bernhard M. Wiedemann
@ 2017-12-05 18:34   ` David Smith
  2017-12-06 13:57     ` [PATCH] Do not add build date into cs man page Bernhard M. Wiedemann
  1 sibling, 1 reply; 6+ messages in thread
From: David Smith @ 2017-12-05 18:34 UTC (permalink / raw)
  To: Bernhard M. Wiedemann; +Cc: systemtap

Commit 8aeb376b6 removes all the 'DATE' processing to make the builds
more reproducible.

On Mon, Nov 27, 2017 at 9:57 AM, David Smith <dsmith@redhat.com> wrote:
> Hmm. I wonder if it wouldn't make more sense just to remove the DATE
> stuff from configure.ac and stappaths.7.in. I'm not sure it adds much
> value. For reference sake, here's the one and only place where DATE is
> used. This is in stappaths.7.in:
>
> This manual page was generated on @DATE@ for systemtap @VERSION@.
>
> On Fri, Nov 24, 2017 at 9:00 AM, Bernhard M. Wiedemann
> <bwiedemann@suse.de> wrote:
>> as date in man page headers, in order to make builds reproducible.
>> See https://reproducible-builds.org/ for why this is good.
>>
>> Also use UTC to be independent of timezone
>>
>> ---
>> While working on making openSUSE Linux package builds reproducible,
>> I found that the systemtap package would differ in the stappaths.7
>> man page
>>
>> An alternative solution could use $SOURCE_DATE_EPOCH
>> to allow to override the date but leave the default behaviour as before.
>> But I think few people care about which date goes into the manual.
>> ---
>>  configure    | 2 +-
>>  configure.ac | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 099664f..1f0b64d 100755
>> --- a/configure
>> +++ b/configure
>> @@ -11451,7 +11451,7 @@ $as_echo "$as_me: staprun will link $staprun_LIBS" >&6;}
>>  $as_echo "$as_me: stapbpf will link $stapbpf_LIBS" >&6;}
>>
>>
>> -date=`date +%Y-%m-%d`
>> +date=`date -u -r NEWS +%Y-%m-%d`
>>
>>  cat >>confdefs.h <<_ACEOF
>>  #define DATE "$date"
>> diff --git a/configure.ac b/configure.ac
>> index a5cb47c..a10fd83 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -598,7 +598,7 @@ AC_MSG_NOTICE([stapbpf will link $stapbpf_LIBS])
>>
>>
>>  dnl Plop in the build (configure) date
>> -date=`date +%Y-%m-%d`
>> +date=`date -u -r NEWS +%Y-%m-%d`
>>  AC_DEFINE_UNQUOTED(DATE, "$date", [Configuration/build date])
>>  AC_SUBST(DATE, "$date")
>>
>> --
>> 2.13.6
>>
>
>
>
> --
> David Smith
> Principal Software Engineer
> Red Hat



-- 
David Smith
Principal Software Engineer
Red Hat

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] Do not add build date into cs man page
  2017-12-05 18:34   ` [PATCH] Use NEWS file date instead of build date David Smith
@ 2017-12-06 13:57     ` Bernhard M. Wiedemann
  2017-12-07 15:58       ` David Smith
  0 siblings, 1 reply; 6+ messages in thread
From: Bernhard M. Wiedemann @ 2017-12-06 13:57 UTC (permalink / raw)
  To: systemtap; +Cc: Bernhard M. Wiedemann

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.

This portion was missing in commit 8aeb376b6
---
 man/cs/stappaths.7.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/cs/stappaths.7.in b/man/cs/stappaths.7.in
index 416393d..eb8ca76 100644
--- a/man/cs/stappaths.7.in
+++ b/man/cs/stappaths.7.in
@@ -18,7 +18,7 @@ stappaths \- důležitá umístění souborů a adresářů systemtapu
 ..
 
 .SH POPIS
-Tato manuálová stránka byla vygenerována @DATE@ pro systemtap @VERSION@.
+Tato manuálová stránka byla vygenerována pro systemtap @VERSION@.
 Následuje seznam důležitých umístění souborů a adresářů.
 
 .TP
-- 
2.13.6

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Do not add build date into cs man page
  2017-12-06 13:57     ` [PATCH] Do not add build date into cs man page Bernhard M. Wiedemann
@ 2017-12-07 15:58       ` David Smith
  0 siblings, 0 replies; 6+ messages in thread
From: David Smith @ 2017-12-07 15:58 UTC (permalink / raw)
  To: Bernhard M. Wiedemann; +Cc: systemtap

Added in commit df9c969e3 (along with one more DATE reference I found).

On Wed, Dec 6, 2017 at 7:57 AM, Bernhard M. Wiedemann
<bwiedemann@suse.de> wrote:
> in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good.
>
> This portion was missing in commit 8aeb376b6
> ---
>  man/cs/stappaths.7.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/cs/stappaths.7.in b/man/cs/stappaths.7.in
> index 416393d..eb8ca76 100644
> --- a/man/cs/stappaths.7.in
> +++ b/man/cs/stappaths.7.in
> @@ -18,7 +18,7 @@ stappaths \- důležitá umístění souborů a adresářů systemtapu
>  ..
>
>  .SH POPIS
> -Tato manuálová stránka byla vygenerována @DATE@ pro systemtap @VERSION@.
> +Tato manuálová stránka byla vygenerována pro systemtap @VERSION@.
>  Následuje seznam důležitých umístění souborů a adresářů.
>
>  .TP
> --
> 2.13.6
>



-- 
David Smith
Principal Software Engineer
Red Hat

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-07 15:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-24 15:01 [PATCH] Use NEWS file date instead of build date Bernhard M. Wiedemann
2017-11-27 15:57 ` David Smith
2017-11-28  8:59   ` [PATCH] Do not add build date into man pages Bernhard M. Wiedemann
2017-12-05 18:34   ` [PATCH] Use NEWS file date instead of build date David Smith
2017-12-06 13:57     ` [PATCH] Do not add build date into cs man page Bernhard M. Wiedemann
2017-12-07 15:58       ` David Smith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).