From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: systemtap@sourceware.org
Subject: [PATCH] Amend fallback comment to work with newer gcc
Date: Mon, 27 Jan 2020 07:26:00 -0000 [thread overview]
Message-ID: <20200127072622.345211-1-siddhesh@gotplt.org> (raw)
Newer gcc does not recognize the fallthrough comment due to the text
following the fallthrough keyword. The "see above" doesn't seem too
valuable, so this patch drops it to fix the build.
---
runtime/unwind/unwind.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/runtime/unwind/unwind.h b/runtime/unwind/unwind.h
index e5a5921ed..7fbe7cc61 100644
--- a/runtime/unwind/unwind.h
+++ b/runtime/unwind/unwind.h
@@ -160,7 +160,7 @@ static unsigned long read_ptr_sect(const u8 **pLoc, const void *end,
#else
BUILD_BUG_ON(sizeof(u32) != sizeof(value));
#endif
- /* fallthrough, see above. */
+ /* fallthrough */
case DW_EH_PE_absptr:
if (compat_task)
{
--
2.24.1
next reply other threads:[~2020-01-27 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 7:26 Siddhesh Poyarekar [this message]
2020-01-27 8:11 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127072622.345211-1-siddhesh@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).