From: Mark Wielaard <mark@klomp.org>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>, systemtap@sourceware.org
Subject: Re: [PATCH] Amend fallback comment to work with newer gcc
Date: Mon, 27 Jan 2020 08:11:00 -0000 [thread overview]
Message-ID: <52ecc5c02ffbfc7573c52813fea5f1b6094d35dc.camel@klomp.org> (raw)
In-Reply-To: <20200127072622.345211-1-siddhesh@gotplt.org>
Hi Siddhesh,
On Mon, 2020-01-27 at 12:56 +0530, Siddhesh Poyarekar wrote:
> Newer gcc does not recognize the fallthrough comment due to the text
> following the fallthrough keyword. The "see above" doesn't seem too
> valuable, so this patch drops it to fix the build.
Thanks. Pushed.
I am slightly surprised gcc made this stricter. But this is more
consistent. This was the only place in the code base where we didn't
use the bare /* fallthrough */ comment.
Cheers,
Mark
prev parent reply other threads:[~2020-01-27 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 7:26 Siddhesh Poyarekar
2020-01-27 8:11 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ecc5c02ffbfc7573c52813fea5f1b6094d35dc.camel@klomp.org \
--to=mark@klomp.org \
--cc=siddhesh@gotplt.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).