public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Tom Stellard <tstellar@redhat.com>
To: systemtap@sourceware.org
Cc: "Timm Bäder" <tbaeder@redhat.com>
Subject: [PATCH 5/8] set2: Return this from assignment operator
Date: Mon, 30 Nov 2020 19:58:38 +0000	[thread overview]
Message-ID: <20201130195841.26142-6-tstellar@redhat.com> (raw)
In-Reply-To: <20201130195841.26142-1-tstellar@redhat.com>

From: Timm Bäder <tbaeder@redhat.com>

This should return something but didn't.
---
 bpf-bitset.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bpf-bitset.h b/bpf-bitset.h
index 6c2f74f0f..4b9402a51 100644
--- a/bpf-bitset.h
+++ b/bpf-bitset.h
@@ -240,6 +240,7 @@ public:
     if (n1 != o.n1 || w2 != o.w2)
       throw_out_of_range("bpf::bitset::set2::operator=");
     memcpy(data, o.data, n1 * w2 * sizeof(word_t));
+    return *this;
   }
 
   set1_ref operator[] (size_t i)
-- 
2.26.2


  parent reply	other threads:[~2020-11-30 19:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 19:58 Clang build fixes Tom Stellard
2020-11-30 19:58 ` [PATCH 1/8] Fix a few class/struct mixups Tom Stellard
2020-11-30 19:58 ` [PATCH 2/8] util: Use abs() instead of labs() Tom Stellard
2020-11-30 19:58 ` [PATCH 3/8] Add some override specifiers where missing Tom Stellard
2020-11-30 19:58 ` [PATCH 4/8] Add missing copy constructors to set1_ref and set1_const_ref Tom Stellard
2020-11-30 19:58 ` Tom Stellard [this message]
2020-11-30 19:58 ` [PATCH 6/8] Fix -Woverloaded-virtual warnings when building with clang Tom Stellard
2020-11-30 19:58 ` [PATCH 7/8] Fix -Wformat-nonliteral and -Wformat warnings " Tom Stellard
2020-11-30 19:58 ` [PATCH 8/8] dtrace: Use -o option to specify output file for CPP Tom Stellard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201130195841.26142-6-tstellar@redhat.com \
    --to=tstellar@redhat.com \
    --cc=systemtap@sourceware.org \
    --cc=tbaeder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).