From: Tom Stellard <tstellar@redhat.com>
To: systemtap@sourceware.org
Cc: "Timm Bäder" <tbaeder@redhat.com>
Subject: [PATCH 1/8] Fix a few class/struct mixups
Date: Mon, 30 Nov 2020 19:58:34 +0000 [thread overview]
Message-ID: <20201130195841.26142-2-tstellar@redhat.com> (raw)
In-Reply-To: <20201130195841.26142-1-tstellar@redhat.com>
From: Timm Bäder <tbaeder@redhat.com>
This breaks the build with clang, e.g.:
./elaborate.h:47:1: error: 'symresolution_info' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
---
dwflpp.h | 2 +-
loc2stap.h | 2 +-
session.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/dwflpp.h b/dwflpp.h
index 25e583908..46813805f 100644
--- a/dwflpp.h
+++ b/dwflpp.h
@@ -182,7 +182,7 @@ struct inline_instance_info : base_func_info
};
struct location;
-struct location_context;
+class location_context;
struct dwflpp
{
diff --git a/loc2stap.h b/loc2stap.h
index 818314bb2..df60571a2 100644
--- a/loc2stap.h
+++ b/loc2stap.h
@@ -41,7 +41,7 @@ struct location
{ }
};
-class dwflpp;
+struct dwflpp;
class location_context
{
public:
diff --git a/session.h b/session.h
index 38f1d66de..f60da3e1e 100644
--- a/session.h
+++ b/session.h
@@ -123,7 +123,7 @@ struct parse_error: public std::runtime_error
};
-class symresolution_info;
+struct symresolution_info;
struct systemtap_session
{
--
2.26.2
next prev parent reply other threads:[~2020-11-30 19:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 19:58 Clang build fixes Tom Stellard
2020-11-30 19:58 ` Tom Stellard [this message]
2020-11-30 19:58 ` [PATCH 2/8] util: Use abs() instead of labs() Tom Stellard
2020-11-30 19:58 ` [PATCH 3/8] Add some override specifiers where missing Tom Stellard
2020-11-30 19:58 ` [PATCH 4/8] Add missing copy constructors to set1_ref and set1_const_ref Tom Stellard
2020-11-30 19:58 ` [PATCH 5/8] set2: Return this from assignment operator Tom Stellard
2020-11-30 19:58 ` [PATCH 6/8] Fix -Woverloaded-virtual warnings when building with clang Tom Stellard
2020-11-30 19:58 ` [PATCH 7/8] Fix -Wformat-nonliteral and -Wformat warnings " Tom Stellard
2020-11-30 19:58 ` [PATCH 8/8] dtrace: Use -o option to specify output file for CPP Tom Stellard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130195841.26142-2-tstellar@redhat.com \
--to=tstellar@redhat.com \
--cc=systemtap@sourceware.org \
--cc=tbaeder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).