public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Makefile.am: remove runtime/linux/uprobes and runtime/linux/uprobes2 install
@ 2023-12-04  3:38 Victor Kamensky
  2023-12-04 11:10 ` Frank Ch. Eigler
  0 siblings, 1 reply; 2+ messages in thread
From: Victor Kamensky @ 2023-12-04  3:38 UTC (permalink / raw)
  To: systemtap; +Cc: Housam Alamour, Frank Ch . Eigler, Victor Kamensky

"PR30434 continuation:  Removed old uprobes, uprobes2 implementation,
uprobes-inc.h & any mentions of CONFIG_UTRACE." commit removed uprobes,
and uprobes2 sources and directories, but Makefile.am still tries to
install them. In fact after failing to 'cd' into runtime/linux/uprobes
directory it copies top level *.[ch] files into
${prefix}/share/systemtap/runtime/linux/uprobes directory.

The issue was caught by OpenEmbedded project do_package_qa checks.

Signed-off-by: Victor Kamensky <victor.kamensky7@gmail.com>
---
 Makefile.am | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 5737c6b20..2ba896088 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -277,10 +277,6 @@ endif
 		do $(INSTALL_DATA) -D $$f $(DESTDIR)$(pkgdatadir)/runtime/softfloat/$$f; done)
 	(cd $(srcdir)/runtime/linux; for f in *.[ch]; \
 		do $(INSTALL_DATA) -D $$f $(DESTDIR)$(pkgdatadir)/runtime/linux/$$f; done)
-	(cd $(srcdir)/runtime/linux/uprobes; for f in Makefile *.[ch]; \
-		do $(INSTALL_DATA) -D $$f $(DESTDIR)$(pkgdatadir)/runtime/linux/uprobes/$$f; done)
-	(cd $(srcdir)/runtime/linux/uprobes2; for f in *.[ch]; \
-		do $(INSTALL_DATA) -D $$f $(DESTDIR)$(pkgdatadir)/runtime/linux/uprobes2/$$f; done)
 	(cd $(srcdir)/tapset; find . \( -name '*.stp' -o -name '*.stpm' -o -name README \) -print \
 		| while read f; do $(INSTALL_DATA) -D $$f $(DESTDIR)$(pkgdatadir)/tapset/$$f; done)
 	(cd $(srcdir)/testsuite/systemtap.examples; find . -type f -print \
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Makefile.am: remove runtime/linux/uprobes and runtime/linux/uprobes2 install
  2023-12-04  3:38 [PATCH] Makefile.am: remove runtime/linux/uprobes and runtime/linux/uprobes2 install Victor Kamensky
@ 2023-12-04 11:10 ` Frank Ch. Eigler
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Ch. Eigler @ 2023-12-04 11:10 UTC (permalink / raw)
  To: Victor Kamensky; +Cc: systemtap, Housam Alamour

Hi -

On Sun, Dec 03, 2023 at 07:38:39PM -0800, Victor Kamensky wrote:
> "PR30434 continuation:  Removed old uprobes, uprobes2 implementation,
> uprobes-inc.h & any mentions of CONFIG_UTRACE." commit removed uprobes,
> and uprobes2 sources and directories, but Makefile.am still tries to
> install them. In fact after failing to 'cd' into runtime/linux/uprobes
> directory it copies top level *.[ch] files into
> ${prefix}/share/systemtap/runtime/linux/uprobes directory.

Thanks, merged.

- FChE


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-04 11:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-04  3:38 [PATCH] Makefile.am: remove runtime/linux/uprobes and runtime/linux/uprobes2 install Victor Kamensky
2023-12-04 11:10 ` Frank Ch. Eigler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).