[Bug runtime/3282] New: staprun failed in relayfs mode

[Bug runtime/3282] New: staprun failed in relayfs mode

[guanglei at cn dot ibm dot com]

I came across this error on latest CVS/ppc64/2.6.17.9/RHEL4U4

root:/home/root> cat a.stp

probe kernel.function("sys_read")
{
        printf("read\n")
}

root:/home/root> stap a.stp -b -v
Pass 1: parsed user script and 53 library script(s) in 590usr/0sys/679real ms.
Pass 2: analyzed script: 1 probe(s), 0 function(s), 0 global(s) in
370usr/40sys/473real ms.
Pass 3: translated to C into "/tmp/stap5V6eQy/stap_7528.c" in
130usr/110sys/270real ms.
Pass 4: compiled C into "stap_7528.ko" in 3270usr/210sys/3891real ms.
Pass 5: starting run.
waitpid: No child processes
Pass 5: run completed in 0usr/20sys/55real ms.
Pass 5: run failed.  Try again with more '-v' (verbose) options.

-- 
           Summary: staprun failed in relayfs mode
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: guanglei at cn dot ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=3282

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/3282] staprun failed in relayfs mode

[guanglei at cn dot ibm dot com]

------- Additional Comments From guanglei at cn dot ibm dot com  2006-09-29 04:51 -------
I checked and found the reason is the due to the failure of:
execlp(stp_check, stp_check, NULL) , which is called inside init_relayfs of
librelayfs.c
the PKGLIBDIR is not defined so execlp can't find the path of stp_check.

Here is a patch, I tested and it works for me:

Index: Makefile.am
===================================================================
RCS file: /cvs/systemtap/src/Makefile.am,v
retrieving revision 1.54
diff -u -r1.54 Makefile.am
--- Makefile.am 26 Sep 2006 21:41:37 -0000      1.54
+++ Makefile.am 29 Sep 2006 04:47:04 -0000
@@ -5,7 +5,7 @@

 pkglibexecdir = ${libexecdir}/${PACKAGE}

-AM_CPPFLAGS = -DBINDIR='"$(bindir)"' -DPKGDATADIR='"${pkgdatadir}"'
+AM_CPPFLAGS = -DBINDIR='"$(bindir)"' -DPKGDATADIR='"${pkgdatadir}"'
-DPKGLIBDIR='"$(pkglibexecdir)"'

 AM_CFLAGS = -std=gnu99 -D_GNU_SOURCE -fexceptions \
            -Wall -Werror -Wshadow -Wunused -Wformat=2 -W


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3282

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/3282] staprun failed in relayfs mode

[guanglei at cn dot ibm dot com]

------- Additional Comments From guanglei at cn dot ibm dot com  2006-09-29 09:13 -------
(In reply to comment #1)

patch checked into CVS.

> I checked and found the reason is the due to the failure of:
> execlp(stp_check, stp_check, NULL) , which is called inside init_relayfs of
> librelayfs.c
> the PKGLIBDIR is not defined so execlp can't find the path of stp_check.
> 
> Here is a patch, I tested and it works for me:
> 
> Index: Makefile.am
> ===================================================================
> RCS file: /cvs/systemtap/src/Makefile.am,v
> retrieving revision 1.54
> diff -u -r1.54 Makefile.am
> --- Makefile.am 26 Sep 2006 21:41:37 -0000      1.54
> +++ Makefile.am 29 Sep 2006 04:47:04 -0000
> @@ -5,7 +5,7 @@
> 
>  pkglibexecdir = ${libexecdir}/${PACKAGE}
> 
> -AM_CPPFLAGS = -DBINDIR='"$(bindir)"' -DPKGDATADIR='"${pkgdatadir}"'
> +AM_CPPFLAGS = -DBINDIR='"$(bindir)"' -DPKGDATADIR='"${pkgdatadir}"'
> -DPKGLIBDIR='"$(pkglibexecdir)"'
> 
>  AM_CFLAGS = -std=gnu99 -D_GNU_SOURCE -fexceptions \
>             -Wall -Werror -Wshadow -Wunused -Wformat=2 -W
> 

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3282

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Re: [Bug runtime/3282] staprun failed in relayfs mode

[David Smith]

guanglei at cn dot ibm dot com wrote:
> ------- Additional Comments From guanglei at cn dot ibm dot com  2006-09-29 09:13 -------
> (In reply to comment #1)
> 
> patch checked into CVS.
> 
>> I checked and found the reason is the due to the failure of:
>> execlp(stp_check, stp_check, NULL) , which is called inside init_relayfs of
>> librelayfs.c
>> the PKGLIBDIR is not defined so execlp can't find the path of stp_check.
>>

Thanks for finding and fixing this problem that I created.  That is the 
one and only reference to PKGLIBDIR left, so hopefully nothing else got 
broken.

-- 
David Smith
dsmith@redhat.com
Red Hat, Inc.
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

[Bug runtime/3282] staprun failed in relayfs mode

[guanglei at cn dot ibm dot com]

------- Additional Comments From guanglei at cn dot ibm dot com  2007-03-01 05:38 -------
This has already been fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=3282

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.