From: David Smith <dsmith@redhat.com>
To: "Stone, Joshua I" <joshua.i.stone@intel.com>
Cc: "Frank Ch. Eigler" <fche@elastic.org>, systemtap@sources.redhat.com
Subject: Re: precompiled probing scenarios
Date: Fri, 20 Oct 2006 19:26:00 -0000 [thread overview]
Message-ID: <453922E8.4000608@redhat.com> (raw)
In-Reply-To: <C56DB814FAA30B418C75310AC4BB279DCC41F4@scsmsx413.amr.corp.intel.com>
Stone, Joshua I wrote:
> On Friday, October 20, 2006 6:50 AM, David Smith wrote:
>> Frank Ch. Eigler wrote:
>>>> Note that currently several tests in the testsuite fail after a
>>>> first run to seed the cache because they don't expect to see the
>>>> skip from pass 2 to pass 5.
>>> How do you mean they fail? -p3 or -p4 should still work.
>> Here's what goes on. The '-p3' and '-p4' options still work. But,
>> several run ('-p5') tests use testsuite/lib/stap_run.exp or
>> testsuite/lib/stap_run2.exp. Those two tcl files expect to see "Pass
>> [12345]" in the output. They get confused when only seeing "Pass
>> [125]" and then think the test has timed out.
>
> Would it make sense to print "dummy" pass 3/4 messages when a cached
> version is used? Something like:
>
> Pass 1: parsed user script and 53 library script(s) in
> 310usr/0sys/326real ms.
> Pass 2: analyzed script: 1 probe(s), 0 function(s), 0 global(s) in
> 10usr/0sys/5real ms.
> Pass 3: (cached) in 0usr/0sys/0real ms.
> Pass 4: (cached) in 0usr/0sys/0real ms.
> Pass 5: starting run.
Actually I've found out that the lack of "Pass [34]" wasn't the problem,
it was the extra cache output messages that was confusing the testsuite.
Here's what the output now looks like (non-cached and cached):
=====
# stap -v -e 'probe begin { log("hi") }'
Pass 1: parsed user script and 53 library script(s) in
680usr/10sys/692real ms.
Pass 2: analyzed script: 1 probe(s), 1 function(s), 0 global(s) in
10usr/0sys/11real ms.
Pass 3: translated to C into
"/tmp/stapYrsXWC/stap_d833fd040735ddde57a23bebb4456542_201.c" in
140usr/90sys/245real ms.
Pass 4: compiled C into "stap_d833fd040735ddde57a23bebb4456542_201.ko"
in 5030usr/550sys/5587real ms.
Copying /tmp/stapYrsXWC/stap_d833fd040735ddde57a23bebb4456542_201.ko to
/home/dsmith/.stap_cache/d/8/stap_d833fd040735ddde57a23bebb4456542_201.ko
Copying /tmp/stapYrsXWC/stap_d833fd040735ddde57a23bebb4456542_201.c to
/home/dsmith/.stap_cache/d/8/stap_d833fd040735ddde57a23bebb4456542_201.c
Pass 5: starting run.
hi
Pass 5: run completed in 10usr/40sys/4634real ms.
# stap -v -e 'probe begin { log("hi") }'
Pass 1: parsed user script and 53 library script(s) in
670usr/20sys/692real ms.
Pass 2: analyzed script: 1 probe(s), 1 function(s), 0 global(s) in
10usr/0sys/11real ms.
Using cached result
"/home/dsmith/.stap_cache/d/8/stap_d833fd040735ddde57a23bebb4456542_201.ko"
as "/tmp/stapJFisJO/stap_d833fd040735ddde57a23bebb4456542_201.ko"
Pass 5: starting run.
hi
Pass 5: run completed in 0usr/40sys/1656real ms.
=====
> The timing info doesn't need to be hardcoded zero, I just expect it
> would be very small.
>
> Side question - do you still use caching when someone calls '-p3' or
> '-p4'? And with verbosity increased, what would this output, given that
> you're not actually doing the work? (e.g., you wouldn't have a compiler
> output on a cached pass-4.)
A module only gets added to the cache if pass 4 completes successfully.
A module (currently) gets pulled from the cache after pass 2, even if
'-p3' or '-p4' was specified on the command line.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
next prev parent reply other threads:[~2006-10-20 19:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 18:44 Stone, Joshua I
2006-10-20 19:26 ` David Smith [this message]
2006-10-20 19:32 ` Frank Ch. Eigler
2006-10-20 19:50 ` David Smith
2006-10-20 20:13 ` Frank Ch. Eigler
2006-10-23 20:36 ` David Smith
-- strict thread matches above, loose matches on Subject: below --
2006-10-25 18:54 Stone, Joshua I
2006-10-26 1:07 ` Frank Ch. Eigler
2006-10-24 0:29 Stone, Joshua I
2006-10-24 15:16 ` David Smith
2006-10-20 20:51 Stone, Joshua I
2006-10-19 20:33 Stone, Joshua I
2006-10-19 20:41 ` David Smith
2006-10-06 19:08 Frank Ch. Eigler
2006-10-06 20:33 ` David Smith
2006-10-06 20:40 ` Frank Ch. Eigler
2006-10-19 19:49 ` David Smith
2006-10-19 21:53 ` Frank Ch. Eigler
2006-10-20 13:50 ` David Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453922E8.4000608@redhat.com \
--to=dsmith@redhat.com \
--cc=fche@elastic.org \
--cc=joshua.i.stone@intel.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).