[PATCH] add testcases for prologue and epilogue style alias

[PATCH] add testcases for prologue and epilogue style alias

[Zhou Wenjian]

    * testsuite/systemtap.base/alias-epilog.exp: New test case.
    * testsuite/systemtap.base/alias-epilog.stp: New test file.
    * testsuite/systemtap.base/alias-prolog.exp: New test case.
    * testsuite/systemtap.base/alias-prolog.stp: New test file.

---
 testsuite/systemtap.base/alias-epilog.exp | 12 ++++++++++++
 testsuite/systemtap.base/alias-epilog.stp | 23 +++++++++++++++++++++++
 testsuite/systemtap.base/alias-prolog.exp | 12 ++++++++++++
 testsuite/systemtap.base/alias-prolog.stp | 23 +++++++++++++++++++++++
 4 files changed, 70 insertions(+)
 create mode 100755 testsuite/systemtap.base/alias-epilog.exp
 create mode 100755 testsuite/systemtap.base/alias-epilog.stp
 create mode 100755 testsuite/systemtap.base/alias-prolog.exp
 create mode 100755 testsuite/systemtap.base/alias-prolog.stp

diff --git a/testsuite/systemtap.base/alias-epilog.exp b/testsuite/systemtap.base/alias-epilog.exp
new file mode 100755
index 0000000..5a2f8b4
--- /dev/null
+++ b/testsuite/systemtap.base/alias-epilog.exp
@@ -0,0 +1,12 @@
+# Check epilogue style alias
+
+set test "alias-epilog"
+
+foreach runtime [get_runtime_list] {
+    if {$runtime != ""} {
+	stap_run $srcdir/$subdir/$test.stp no_load $all_pass_string \
+	    --runtime=$runtime
+    } else {
+	stap_run $srcdir/$subdir/$test.stp no_load $all_pass_string
+    }
+}
diff --git a/testsuite/systemtap.base/alias-epilog.stp b/testsuite/systemtap.base/alias-epilog.stp
new file mode 100755
index 0000000..d734b63
--- /dev/null
+++ b/testsuite/systemtap.base/alias-epilog.stp
@@ -0,0 +1,23 @@
+/*
+ * alias-epilog.stp
+ *
+ * Check epilogue style alias
+ */
+
+probe foo = begin { }
+
+probe begin
+{
+    println("systemtap starting probe")
+    exit()
+}
+
+probe end1 += end
+{
+    println("systemtap test success")
+}
+
+probe end1
+{
+    println("systemtap ending probe")
+}
diff --git a/testsuite/systemtap.base/alias-prolog.exp b/testsuite/systemtap.base/alias-prolog.exp
new file mode 100755
index 0000000..63de3d3
--- /dev/null
+++ b/testsuite/systemtap.base/alias-prolog.exp
@@ -0,0 +1,12 @@
+# Check prologue style alias
+
+set test "alias-prolog"
+
+foreach runtime [get_runtime_list] {
+    if {$runtime != ""} {
+	stap_run $srcdir/$subdir/$test.stp no_load $all_pass_string \
+	    --runtime=$runtime
+    } else {
+	stap_run $srcdir/$subdir/$test.stp no_load $all_pass_string
+    }
+}
diff --git a/testsuite/systemtap.base/alias-prolog.stp b/testsuite/systemtap.base/alias-prolog.stp
new file mode 100755
index 0000000..6de91fa
--- /dev/null
+++ b/testsuite/systemtap.base/alias-prolog.stp
@@ -0,0 +1,23 @@
+/*
+ * alias-prolog.stp
+ *
+ * Check prologue style alias
+ */
+
+probe foo = begin { }
+
+probe begin
+{
+    println("systemtap starting probe")
+    exit()
+}
+
+probe end1 = end
+{
+    println("systemtap ending probe")
+}
+
+probe end1
+{
+    println("systemtap test success")
+}
-- 
1.8.3.1

Re: [PATCH] add testcases for prologue and epilogue style alias

[David Smith]

On 10/20/2015 09:33 PM, Zhou Wenjian wrote:
>     * testsuite/systemtap.base/alias-epilog.exp: New test case.
>     * testsuite/systemtap.base/alias-epilog.stp: New test file.
>     * testsuite/systemtap.base/alias-prolog.exp: New test case.
>     * testsuite/systemtap.base/alias-prolog.stp: New test file.

Thanks so much for the patch. I've checked it in for you (with one small
tweak to return if we're doing "make check").

Thanks again!

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

Re: [PATCH] add testcases for prologue and epilogue style alias

["Zhou, Wenjian/周文剑"]

Hello David,

Thanks for your quick reply.
Could you tell me what the tweak is?
Then I will improve my work in the following cases.

-- 
Thanks
Zhou

On 10/23/2015 12:25 AM, David Smith wrote:
> On 10/20/2015 09:33 PM, Zhou Wenjian wrote:
>>      * testsuite/systemtap.base/alias-epilog.exp: New test case.
>>      * testsuite/systemtap.base/alias-epilog.stp: New test file.
>>      * testsuite/systemtap.base/alias-prolog.exp: New test case.
>>      * testsuite/systemtap.base/alias-prolog.stp: New test file.
>
> Thanks so much for the patch. I've checked it in for you (with one small
> tweak to return if we're doing "make check").
>
> Thanks again!
>

Re: [PATCH] add testcases for prologue and epilogue style alias

[Frank Ch. Eigler]

=?UTF-8?B?Ilpob3UsIFdlbmppYW4v5ZGo5paH5YmRIg==?= <zhouwj-fnst@cn.fujitsu.com> writes:

> Could you tell me what the tweak is?
> Then I will improve my work in the following cases.

David was referring to this bit:

    if {![installtest_p]} { untested "$test"; return }

This is needed to make "make check" work by bypassing tests
that require full stap script invocation.

- FChE

Re: [PATCH] add testcases for prologue and epilogue style alias

[David Smith]

On 10/23/2015 08:50 AM, Frank Ch. Eigler wrote:
> =?UTF-8?B?Ilpob3UsIFdlbmppYW4v5ZGo5paH5YmRIg==?= <zhouwj-fnst@cn.fujitsu.com> writes:
> 
>> Could you tell me what the tweak is?
>> Then I will improve my work in the following cases.
> 
> David was referring to this bit:
> 
>     if {![installtest_p]} { untested "$test"; return }
> 
> This is needed to make "make check" work by bypassing tests
> that require full stap script invocation.

Frank is correct. Here's the full commit in case you want to see it:

<https://www.sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commitdiff;h=c5656db9d82ffe791e81ab0b2b841a262a1f1e68>


-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

Re: [PATCH] add testcases for prologue and epilogue style alias

["Zhou, Wenjian/周文剑"]

On 10/23/2015 09:50 PM, Frank Ch. Eigler wrote:
> =?UTF-8?B?Ilpob3UsIFdlbmppYW4v5ZGo5paH5YmRIg==?= <zhouwj-fnst@cn.fujitsu.com> writes:
>
>> Could you tell me what the tweak is?
>> Then I will improve my work in the following cases.
>
> David was referring to this bit:
>
>      if {![installtest_p]} { untested "$test"; return }
>
> This is needed to make "make check" work by bypassing tests
> that require full stap script invocation.
>

Thanks for telling me that.

-- 
Thanks
Zhou