public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Torsten Polle <Torsten.Polle@gmx.de>
To: smakarov@redhat.com
Cc: systemtap@sourceware.org
Subject: PR11599: update STAPCONF_TRACEPOINT_HAS_DATA to work with kernel 5.7.0+
Date: Sun, 24 May 2020 16:07:41 +0200	[thread overview]
Message-ID: <6D776DD5-8DD9-41C7-B166-25EDD6B81857@gmx.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi Serhei,

Your patch introduces a new source for the definition of STAPCONF_TRACEPOINT_HAS_DATA in the files generated by autoconf, which conflicts with the original definition stp_tracepoints.h.

The following patch remedies this situation at least in my environment. But I wonder whether the definition in stp_tracepoints.h could be simply removed.

Kind Regards,
Torsten

[-- Attachment #2: PR11599-Fix-STAPCONF_TRACEPOINT_HAS_DATA-already-def.patch --]
[-- Type: application/octet-stream, Size: 854 bytes --]

From ec0017bf86606f87703a2b8345f49dc0eebf363c Mon Sep 17 00:00:00 2001
From: Torsten Polle <Torsten.Polle@gmx.de>
Date: Sun, 24 May 2020 10:49:35 +0200
Subject: [PATCH] PR11599: Fix: STAPCONF_TRACEPOINT_HAS_DATA already defined.

---
 runtime/linux/stp_tracepoint.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/runtime/linux/stp_tracepoint.h b/runtime/linux/stp_tracepoint.h
index cb8d335..e66cd4f 100644
--- a/runtime/linux/stp_tracepoint.h
+++ b/runtime/linux/stp_tracepoint.h
@@ -21,7 +21,9 @@
  * Since NOARGS was removed in 5.7.0, this configuration is now also
  * checked with autoconf-tracepoint-has-data.c. */
 #ifdef DECLARE_TRACE_NOARGS
-#define STAPCONF_TRACEPOINT_HAS_DATA
+#  ifndef STAPCONF_TRACEPOINT_HAS_DATA
+#    define STAPCONF_TRACEPOINT_HAS_DATA
+#  endif
 #endif
 
 
-- 
2.7.4


             reply	other threads:[~2020-05-24 14:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-24 14:07 Torsten Polle [this message]
2020-05-25 13:39 ` Serhei Makarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D776DD5-8DD9-41C7-B166-25EDD6B81857@gmx.de \
    --to=torsten.polle@gmx.de \
    --cc=smakarov@redhat.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).