From: "Serhei Makarov" <me@serhei.io>
To: "Torsten Polle" <Torsten.Polle@gmx.de>,
"Serhei Makarov" <smakarov@redhat.com>
Cc: systemtap <systemtap@sourceware.org>
Subject: Re: PR11599: update STAPCONF_TRACEPOINT_HAS_DATA to work with kernel 5.7.0+
Date: Mon, 25 May 2020 09:39:35 -0400 [thread overview]
Message-ID: <bdcfba66-2f9d-4b4d-a5f4-4a88a5838bcc@www.fastmail.com> (raw)
In-Reply-To: <6D776DD5-8DD9-41C7-B166-25EDD6B81857@gmx.de>
Hello Torsten,
Thank you very much for testing the change! I went to apply your patch this morning and saw that Frank also caught the same problem and fixed it with commit 823a77ab03c3. If that approach to fix it still generates a warning, I'll apply your patch.
In answer to your question, to remove the definition of stp_tracepoints.h, the autoconf file must compile correctly on every prior kernel version where DECLARE_TRACE_NOARGS was defined.
I have not verified this, so I can only be certain the autoconf check is appropriate for kernel 5.7+.
For earlier versions, we continue to check for DECLARE_TRACE_NOARGS.
All the best,
Serhei
On Sun, May 24, 2020, at 10:07 AM, Torsten Polle wrote:
> Hi Serhei,
>
> Your patch introduces a new source for the definition of
> STAPCONF_TRACEPOINT_HAS_DATA in the files generated by autoconf, which
> conflicts with the original definition stp_tracepoints.h.
>
> The following patch remedies this situation at least in my environment.
> But I wonder whether the definition in stp_tracepoints.h could be
> simply removed.
>
> Kind Regards,
> Torsten
>
> Attachments:
> * PR11599-Fix-STAPCONF_TRACEPOINT_HAS_DATA-already-def.patch
prev parent reply other threads:[~2020-05-25 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 14:07 Torsten Polle
2020-05-25 13:39 ` Serhei Makarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdcfba66-2f9d-4b4d-a5f4-4a88a5838bcc@www.fastmail.com \
--to=me@serhei.io \
--cc=Torsten.Polle@gmx.de \
--cc=smakarov@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).