public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Gioele Barabucci <gioele@svario.it>
Cc: Gioele Barabucci via Systemtap <systemtap@sourceware.org>
Subject: Re: [PATCH] dtrace: Use deterministic temp file creation for all temp files
Date: Mon, 27 Feb 2023 18:34:57 +0100	[thread overview]
Message-ID: <87edqbko5a.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <9af13f7f-6633-6552-c572-92a45c80c743@svario.it> (Gioele Barabucci's message of "Mon, 27 Feb 2023 18:15:02 +0100")

* Gioele Barabucci:

> @@ -380,6 +373,7 @@ def main():
>          usage()
>          return 1
>  
> +    TEMP_DIR = mkdtemp()
>      if s_filename != "" and use_cpp:
>          (ignore, fname) = mktemp_determ(["use_cpp", s_filename], suffix=".d")
>          cpp = os.environ.get("CPP", "cpp")
> @@ -458,6 +452,9 @@ def main():
>          else:
>              print("cpp: " + s_filename)
>  
> +    if not keep_temps:
> +        os.rmdir(TEMP_DIR)

This should probably use try:/finally: or a context manager
with tempfile.TemporaryDirectory.

Thanks,
Florian


  reply	other threads:[~2023-02-27 17:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 12:13 Gioele Barabucci
2023-02-27 15:49 ` Florian Weimer
2023-02-27 15:59   ` Gioele Barabucci
2023-02-27 16:47     ` Florian Weimer
2023-02-27 17:15       ` Gioele Barabucci
2023-02-27 17:34         ` Florian Weimer [this message]
2023-02-28  3:46           ` Gioele Barabucci
2023-02-28 10:12             ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edqbko5a.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=gioele@svario.it \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).