* Re: [PATCH] buildrun: remove quotes around -I include line
@ 2017-05-05 20:48 Torsten Polle
2017-05-07 3:34 ` Frank Ch. Eigler
0 siblings, 1 reply; 3+ messages in thread
From: Torsten Polle @ 2017-05-05 20:48 UTC (permalink / raw)
To: systemtap
> By having the quotes, the kernel Makefile addtree macro adds the
> kernel $srctree directory as a prefix and causes compilation failures.
> Removing the quotes resolves the issue.
>
> This is trimmed from the verbose output of the GCC command line
> Before:
> -I/srv/sdb/builds/4.9/tmp/work-shared/qemux86-64/kernel-source/"/srv/sdb/releases/jethro/builds/4.1/tmp/sysroots/x86_64-linux/usr/share/systemtap/runtime"
>
> After:
> -I/srv/sdb/builds/4.9/tmp/sysroots/x86_64-linux/usr/share/systemtap/runtime
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> buildrun.cxx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildrun.cxx b/buildrun.cxx
> index aaea64c..8a8ee9f 100644
> --- a/buildrun.cxx
> +++ b/buildrun.cxx
> @@ -495,7 +495,7 @@ compile_pass (systemtap_session& s)
> #if CHECK_POINTER_ARITH_PR5947
> o << "EXTRA_CFLAGS += -Wpointer-arith" << endl;
> #endif
> - o << "EXTRA_CFLAGS += -I\"" << s.runtime_path << "\"" << endl;
> + o << "EXTRA_CFLAGS += -I" << s.runtime_path << endl;
> // XXX: this may help ppc toc overflow
> // o << "CFLAGS := $(subst -Os,-O2,$(CFLAGS)) -fminimal-toc" << endl;
> o << "obj-m := " << s.module_name << ".o" << endl;
> --
> 2.7.4
Hi,
as I also need this patch, I would like to check on the status. I've not seen this patch applied yet. Did I miss something?
Kind Regards,
Torsten
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] buildrun: remove quotes around -I include line
2017-05-05 20:48 [PATCH] buildrun: remove quotes around -I include line Torsten Polle
@ 2017-05-07 3:34 ` Frank Ch. Eigler
0 siblings, 0 replies; 3+ messages in thread
From: Frank Ch. Eigler @ 2017-05-07 3:34 UTC (permalink / raw)
To: Torsten Polle; +Cc: systemtap
Torsten.Polle wrote:
> [...]
> > - o << "EXTRA_CFLAGS += -I\"" << s.runtime_path << "\"" << endl;
> > + o << "EXTRA_CFLAGS += -I" << s.runtime_path << endl;
> as I also need this patch, I would like to check on the status. I've
> not seen this patch applied yet. Did I miss something?
The patch would work around an as-yet-unidentified kbuild scripting bug
somewhere, but would break builds with a runtime_path containing spaces.
Maybe that's OK.
- FChE
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] buildrun: remove quotes around -I include line
@ 2017-03-07 20:04 Saul Wold
0 siblings, 0 replies; 3+ messages in thread
From: Saul Wold @ 2017-03-07 20:04 UTC (permalink / raw)
To: systemtap
By having the quotes, the kernel Makefile addtree macro adds the
kernel $srctree directory as a prefix and causes compilation failures.
Removing the quotes resolves the issue.
This is trimmed from the verbose output of the GCC command line
Before:
-I/srv/sdb/builds/4.9/tmp/work-shared/qemux86-64/kernel-source/"/srv/sdb/releases/jethro/builds/4.1/tmp/sysroots/x86_64-linux/usr/share/systemtap/runtime"
After:
-I/srv/sdb/builds/4.9/tmp/sysroots/x86_64-linux/usr/share/systemtap/runtime
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
buildrun.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/buildrun.cxx b/buildrun.cxx
index aaea64c..8a8ee9f 100644
--- a/buildrun.cxx
+++ b/buildrun.cxx
@@ -495,7 +495,7 @@ compile_pass (systemtap_session& s)
#if CHECK_POINTER_ARITH_PR5947
o << "EXTRA_CFLAGS += -Wpointer-arith" << endl;
#endif
- o << "EXTRA_CFLAGS += -I\"" << s.runtime_path << "\"" << endl;
+ o << "EXTRA_CFLAGS += -I" << s.runtime_path << endl;
// XXX: this may help ppc toc overflow
// o << "CFLAGS := $(subst -Os,-O2,$(CFLAGS)) -fminimal-toc" << endl;
o << "obj-m := " << s.module_name << ".o" << endl;
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-07 3:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-05 20:48 [PATCH] buildrun: remove quotes around -I include line Torsten Polle
2017-05-07 3:34 ` Frank Ch. Eigler
-- strict thread matches above, loose matches on Subject: below --
2017-03-07 20:04 Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).