* [PATCH] Add the '-p4' options when exemplifying the module compilation
@ 2016-06-27 16:46 Nikolay Borisov
2016-06-27 17:14 ` Josh Stone
0 siblings, 1 reply; 6+ messages in thread
From: Nikolay Borisov @ 2016-06-27 16:46 UTC (permalink / raw)
To: systemtap; +Cc: fche, Nikolay Borisov
Currently the example command which supposedly should compile the
instrumentation module is missing the '-p4' option, meaning that
upon running it will compile and run the module. In order to make
the command more in sync with what this particular chapter is about,
add the -p4 options so that after running the command the user gets
to copy the resulting module.
Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
---
doc/SystemTap_Beginners_Guide/en-US/CrossInstrumenting.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/SystemTap_Beginners_Guide/en-US/CrossInstrumenting.xml b/doc/SystemTap_Beginners_Guide/en-US/CrossInstrumenting.xml
index 3e5a4855ec60..c840a969014f 100644
--- a/doc/SystemTap_Beginners_Guide/en-US/CrossInstrumenting.xml
+++ b/doc/SystemTap_Beginners_Guide/en-US/CrossInstrumenting.xml
@@ -258,7 +258,7 @@
appropriate values):
</para>
-<screen><command>stap -r <replaceable>kernel_version</replaceable> <replaceable>script</replaceable> -m <replaceable>module_name</replaceable></command></screen>
+<screen><command>stap -p4 -r <replaceable>kernel_version</replaceable> <replaceable>script</replaceable> -m <replaceable>module_name</replaceable></command></screen>
<para>
Here, <replaceable>kernel_version</replaceable> refers to
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add the '-p4' options when exemplifying the module compilation
2016-06-27 16:46 [PATCH] Add the '-p4' options when exemplifying the module compilation Nikolay Borisov
@ 2016-06-27 17:14 ` Josh Stone
2016-06-28 0:41 ` nborisov
0 siblings, 1 reply; 6+ messages in thread
From: Josh Stone @ 2016-06-27 17:14 UTC (permalink / raw)
To: Nikolay Borisov, systemtap; +Cc: fche
On 06/27/2016 09:46 AM, Nikolay Borisov wrote:
> Currently the example command which supposedly should compile the
> instrumentation module is missing the '-p4' option, meaning that
> upon running it will compile and run the module. In order to make
> the command more in sync with what this particular chapter is about,
> add the -p4 options so that after running the command the user gets
> to copy the resulting module.
It's implicitly limited to -p4 already when the chosen -r kernel doesn't
match the locally running kernel. You'll see:
WARNING: kernel release/architecture mismatch with host forces
last-pass 4.
Making it explicit to avoid the warning is good though. It looks like
fche already pushed your patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add the '-p4' options when exemplifying the module compilation
2016-06-27 17:14 ` Josh Stone
@ 2016-06-28 0:41 ` nborisov
2016-06-28 0:44 ` Josh Stone
0 siblings, 1 reply; 6+ messages in thread
From: nborisov @ 2016-06-28 0:41 UTC (permalink / raw)
To: Josh Stone, systemtap; +Cc: fche
On 27.06.2016 20:14, Josh Stone wrote:
> On 06/27/2016 09:46 AM, Nikolay Borisov wrote:
>> Currently the example command which supposedly should compile the
>> instrumentation module is missing the '-p4' option, meaning that
>> upon running it will compile and run the module. In order to make
>> the command more in sync with what this particular chapter is about,
>> add the -p4 options so that after running the command the user gets
>> to copy the resulting module.
>
> It's implicitly limited to -p4 already when the chosen -r kernel doesn't
> match the locally running kernel. You'll see:
Actually when I ran the command given in the book, the script would
compile and run.
>
> WARNING: kernel release/architecture mismatch with host forces
> last-pass 4.
>
> Making it explicit to avoid the warning is good though. It looks like
> fche already pushed your patch.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add the '-p4' options when exemplifying the module compilation
2016-06-28 0:41 ` nborisov
@ 2016-06-28 0:44 ` Josh Stone
2016-06-28 6:16 ` Nikolay Borisov
0 siblings, 1 reply; 6+ messages in thread
From: Josh Stone @ 2016-06-28 0:44 UTC (permalink / raw)
To: nborisov, systemtap; +Cc: fche
On 06/27/2016 05:40 PM, nborisov wrote:
>
>
> On 27.06.2016 20:14, Josh Stone wrote:
>> On 06/27/2016 09:46 AM, Nikolay Borisov wrote:
>>> Currently the example command which supposedly should compile the
>>> instrumentation module is missing the '-p4' option, meaning that
>>> upon running it will compile and run the module. In order to make
>>> the command more in sync with what this particular chapter is about,
>>> add the -p4 options so that after running the command the user gets
>>> to copy the resulting module.
>>
>> It's implicitly limited to -p4 already when the chosen -r kernel doesn't
>> match the locally running kernel. You'll see:
>
> Actually when I ran the command given in the book, the script would
> compile and run.
Was your "-r kernel" the same as the running kernel?
Otherwise it really shouldn't happen, so we may have a bug...
>> WARNING: kernel release/architecture mismatch with host forces
>> last-pass 4.
>>
>> Making it explicit to avoid the warning is good though. It looks like
>> fche already pushed your patch.
>
>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add the '-p4' options when exemplifying the module compilation
2016-06-28 0:44 ` Josh Stone
@ 2016-06-28 6:16 ` Nikolay Borisov
2016-06-28 16:25 ` Josh Stone
0 siblings, 1 reply; 6+ messages in thread
From: Nikolay Borisov @ 2016-06-28 6:16 UTC (permalink / raw)
To: Josh Stone, systemtap; +Cc: fche
On 06/28/2016 03:44 AM, Josh Stone wrote:
> On 06/27/2016 05:40 PM, nborisov wrote:
>>
>>
>> On 27.06.2016 20:14, Josh Stone wrote:
>>> On 06/27/2016 09:46 AM, Nikolay Borisov wrote:
>>>> Currently the example command which supposedly should compile the
>>>> instrumentation module is missing the '-p4' option, meaning that
>>>> upon running it will compile and run the module. In order to make
>>>> the command more in sync with what this particular chapter is about,
>>>> add the -p4 options so that after running the command the user gets
>>>> to copy the resulting module.
>>>
>>> It's implicitly limited to -p4 already when the chosen -r kernel doesn't
>>> match the locally running kernel. You'll see:
>>
>> Actually when I ran the command given in the book, the script would
>> compile and run.
>
> Was your "-r kernel" the same as the running kernel?
> Otherwise it really shouldn't happen, so we may have a bug...
Yes, when the kernel being compiled for is the same as the running it
seems the script is being loaded. In either case, though, I wasn't
expecting for the script to actually load.
>
>>> WARNING: kernel release/architecture mismatch with host forces
>>> last-pass 4.
>>>
>>> Making it explicit to avoid the warning is good though. It looks like
>>> fche already pushed your patch.
>>
>>
>>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add the '-p4' options when exemplifying the module compilation
2016-06-28 6:16 ` Nikolay Borisov
@ 2016-06-28 16:25 ` Josh Stone
0 siblings, 0 replies; 6+ messages in thread
From: Josh Stone @ 2016-06-28 16:25 UTC (permalink / raw)
To: Nikolay Borisov, systemtap; +Cc: fche
On 06/27/2016 11:16 PM, Nikolay Borisov wrote:
>
>
> On 06/28/2016 03:44 AM, Josh Stone wrote:
>> On 06/27/2016 05:40 PM, nborisov wrote:
>>>
>>>
>>> On 27.06.2016 20:14, Josh Stone wrote:
>>>> On 06/27/2016 09:46 AM, Nikolay Borisov wrote:
>>>>> Currently the example command which supposedly should compile the
>>>>> instrumentation module is missing the '-p4' option, meaning that
>>>>> upon running it will compile and run the module. In order to make
>>>>> the command more in sync with what this particular chapter is about,
>>>>> add the -p4 options so that after running the command the user gets
>>>>> to copy the resulting module.
>>>>
>>>> It's implicitly limited to -p4 already when the chosen -r kernel doesn't
>>>> match the locally running kernel. You'll see:
>>>
>>> Actually when I ran the command given in the book, the script would
>>> compile and run.
>>
>> Was your "-r kernel" the same as the running kernel?
>> Otherwise it really shouldn't happen, so we may have a bug...
>
> Yes, when the kernel being compiled for is the same as the running it
> seems the script is being loaded. In either case, though, I wasn't
> expecting for the script to actually load.
OK, that's fine. Using an explicit -p4 is correct to make sure that it
always stops before loading.
>>>> WARNING: kernel release/architecture mismatch with host forces
>>>> last-pass 4.
>>>>
>>>> Making it explicit to avoid the warning is good though. It looks like
>>>> fche already pushed your patch.
>>>
>>>
>>>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-28 16:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-27 16:46 [PATCH] Add the '-p4' options when exemplifying the module compilation Nikolay Borisov
2016-06-27 17:14 ` Josh Stone
2016-06-28 0:41 ` nborisov
2016-06-28 0:44 ` Josh Stone
2016-06-28 6:16 ` Nikolay Borisov
2016-06-28 16:25 ` Josh Stone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).