public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* Ignore -xflags not separated by a space
@ 2024-01-30  0:16 Matt Rice
  0 siblings, 0 replies; only message in thread
From: Matt Rice @ 2024-01-30  0:16 UTC (permalink / raw)
  To: systemtap

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

The ignore_options2 currently ignores flags like '-x flags', skipping
the next argument,
but it lets cases like '-xflags'  fall through.

This can be seen in a couple of places primarily with -xnolibs:
https://github.com/joyent/libuv/issues/1478
https://github.com/agentzh/usdt-sample

[-- Attachment #2: 0001-ignore-for-xflags-not-separated-by-a-space.patch --]
[-- Type: text/x-patch, Size: 845 bytes --]

From 1b13d0263df84a98b0d7ac4e5c4d111136addd83 Mon Sep 17 00:00:00 2001
From: matt rice <ratmice@gmail.com>
Date: Mon, 29 Jan 2024 16:02:44 -0800
Subject: [PATCH] ignore for -xflags not separated by a space.

Signed-off-by: matt rice <ratmice@gmail.com>
---
 dtrace.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dtrace.in b/dtrace.in
index 73a6f22e2..1a762c7a5 100644
--- a/dtrace.in
+++ b/dtrace.in
@@ -369,6 +369,8 @@ def main():
         elif sys.argv[i] in ignore_options2:
             i += 1
             pass                # dtrace users sometimes pass these flags
+        elif sys.argv[i].startswith(tuple(ignore_options2)):
+            pass                # dtrace users sometimes pass flags like '-xnolibs'
         elif sys.argv[i] == "--help":
             dtrace_help()
         elif sys.argv[i][0] == "-":
-- 
2.43.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-01-30  0:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-30  0:16 Ignore -xflags not separated by a space Matt Rice

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).