public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Craig Ringer <craig@2ndquadrant.com>
To: systemtap@sourceware.org
Cc: "Frank Ch. Eigler" <fche@redhat.com>
Subject: Emitting marker names instead of hex statement addresses for SDT probes?
Date: Wed, 13 Jan 2021 12:49:27 +0800	[thread overview]
Message-ID: <CAMsr+YFZPEPqS+qoPNLTd3q8gBs9f29nXMd5k4Ouzhj8G5RSkg@mail.gmail.com> (raw)

Hi all

I'm looking for advice on how feasible it might be to have systemtap report
the SDT marker name in the probe-point name, instead of a
.statement(0xdeadbeef) string.

Because probes like process("foo").mark("bar") are converted to
process("foo").statement(0xdeadbeef), the monitor mode display is nearly
useless for SDTs. You just get a wall of undifferentiated hex statement
addresses. It also makes various errors and diagnostics much more difficult
to act on, and makes the output of pp() nearly useless for SDT markers.

Any advice on where I might start looking in the code if I wanted to change
this?

Also, ideally I'd also like to have $$name do something sensible for all
probe point types, so I don't need to

    defined($$name) ? $$name : ppfunc()

in macros and functions that can be invoked by both marker based and
DWARF-based probes.

Any thoughts on the most sensible value to assign to $$name for other probe
types? It could resolve to pp(), but that can be very long and verbose.
ppfunc() would be logical for function based probes but for others it's
less obvious.




-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 2ndQuadrant - PostgreSQL Solutions for the Enterprise

             reply	other threads:[~2021-01-13  4:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13  4:49 Craig Ringer [this message]
2021-01-19 22:21 ` Stan Cox
2021-01-21  5:47   ` Craig Ringer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMsr+YFZPEPqS+qoPNLTd3q8gBs9f29nXMd5k4Ouzhj8G5RSkg@mail.gmail.com \
    --to=craig@2ndquadrant.com \
    --cc=fche@redhat.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).