[Bug translator/10607] need way to protect sensitive tapset globals

[Bug translator/10607] need way to protect sensitive tapset globals

[fche at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=10607

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|need way to disable         |need way to protect
                   |global-setting module       |sensitive tapset globals
                   |params                      |

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> 2012-05-16 15:53:27 UTC ---
Note that it's not sufficient to just disable -G foo=bar.  An end-user script
could equivalently include  probe begin(1) { tapset_global = naughty_value } to
mess with this.  So we'd need a more general mechanism to protect tapset
internal globals, whose change could cause problems.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug translator/10607] need way to protect sensitive tapset globals

[fche at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=10607

--- Comment #2 from Frank Ch. Eigler <fche at redhat dot com> 2012-07-10 20:23:47 UTC ---
(In reply to comment #1)
> Note that it's not sufficient to just disable -G foo=bar.  An end-user script
> could equivalently include  probe begin(1) { tapset_global = naughty_value } to
> mess with this.

... but that's not a problem, as in the original scenario, an existing
signed/special .ko is interfered with.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug translator/10607] need way to protect sensitive tapset globals

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=10607

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mcermak at redhat dot com
         Resolution|---                         |FIXED

--- Comment #3 from Martin Cermak <mcermak at redhat dot com> ---
Can be done using private global variable introduced by PR19136: 

=======
$ stap -e 'global gt=5; private pt=6; probe oneshot {println(gt, ",", pt)}'
5,6
$ stap -G gt=7 -e 'global gt=5; private pt=6; probe oneshot {println(gt, ",",
pt)}'
7,6
$ stap -G pt=7 -e 'global gt=5; private pt=6; probe oneshot {println(gt, ",",
pt)}'
ERROR: Couldn't insert module
'/tmp/stapJOEsIt/stap_c338a51e10d33545e0988128fc6f2e20_1117.ko': Unknown symbol
in module
WARNING: /usr/local/bin/staprun exited with status: 1
Pass 5: run failed.  [man error::pass5]
$ stap --dyninst -G pt=7 -e 'global gt=5; private pt=6; probe oneshot
{println(gt, ",", pt)}'
stapdyn: WARNING: Ignoring unknown module option '__global_pt'
5,6
$
=======

Commit 1b9d316 extends the private.exp testcase to cover this scenario.

-- 
You are receiving this mail because:
You are the assignee for the bug.