[Bug translator/12592] New: Compile server should support non-standard kernel paths

[Bug translator/12592] New: Compile server should support non-standard kernel paths

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12592

           Summary: Compile server should support non-standard kernel
                    paths
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap@sourceware.org
        ReportedBy: jistone@redhat.com


On my F14-x86_64 computer, I'm trying to setup a cross-compile server to
service an i386 virtual machine.  I downloaded kernel-devel-PAE and extracted
it in my home directory.  I can manually cross-compile like so:

> $ stap -e 'probe begin, end { println(pp()) }' -a i386 -r ~/kernel-PAE-devel-2.6.35.11-83.fc14.i686/usr/src/kernels/2.6.35.11-83.fc14.i686.PAE/ -p4
> /home/jistone/.systemtap/cache/ed/stap_ed7320327d72e18ac47c2a86509e358b_2102.ko
> $ file /home/jistone/.systemtap/cache/ed/stap_ed7320327d72e18ac47c2a86509e358b_2102.ko
> /home/jistone/.systemtap/cache/ed/stap_ed7320327d72e18ac47c2a86509e358b_2102.ko: ELF 32-bit LSB relocatable, Intel 80386, version 1 (SYSV), not stripped

Then I tried it with a compile server:

> $ /usr/local/libexec/systemtap/stap-start-server -r ~/kernel-PAE-devel-2.6.35.11-83.fc14.i686/usr/src/kernels/2.6.35.11-83.fc14.i686.PAE/ -a i386
> 31762
> $ stap --list-servers=online
> Systemtap Compile Server Status for 'online'
>  host=jistone-t61 ip=192.168.0.135 port=12972 sysinfo="2.6.35.11-83.fc14.i686.PAE i386" certinfo="00:91:66:ee:c3"
> $ stap -ve 'probe begin, end { println(pp()) }' -a i386 -r 2.6.35.11-83.fc14.i686.PAE -p4 --use-server
> Checking "/lib/modules/2.6.35.11-83.fc14.i686.PAE/build/.config" failed with error: No such file or directory
> Passes: via server jistone-t61 [192.168.0.135:12972] using 181340virt/5212res/4348shr kb, in 10usr/20sys/2190real ms.

I believe the issue is that function process_r in stap-serverd is only using
the path to identify the uname_r.  It should be passing my full path into
stap_options, as that kernel isn't found in /lib/modules.  The stap-server
initscript appears to have a similar problem.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug translator/12592] Compile server should support non-standard kernel paths

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12592

--- Comment #1 from Josh Stone <jistone at redhat dot com> 2011-03-17 22:47:55 UTC ---
Created attachment 5317
  --> http://sourceware.org/bugzilla/attachment.cgi?id=5317
Allow full kernel paths with the server

This seems to be enough to fix it - please review and make sure I'm not missing
something subtle here...

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug translator/12592] Compile server should support non-standard kernel paths

[brolley at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12592

--- Comment #2 from Dave Brolley <brolley at redhat dot com> 2011-03-18 14:54:00 UTC ---
(In reply to comment #1)
> Created attachment 5317 [details]
> Allow full kernel paths with the server
> 
> This seems to be enough to fix it - please review and make sure I'm not missing
> something subtle here...

Yes, it makes sense to pass the release through as it was specified. Thanks!

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug translator/12592] Compile server should support non-standard kernel paths

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12592

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Josh Stone <jistone at redhat dot com> 2011-03-19 01:37:37 UTC ---
Thanks, pushed as commit 4f747a6.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.