[Bug runtime/13440] New: cast.exp fails on s390x umod cast in (kernel) begin probe

[Bug runtime/13440] New: cast.exp fails on s390x umod cast in (kernel) begin probe

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13440

             Bug #: 13440
           Summary: cast.exp fails on s390x umod cast in (kernel) begin
                    probe
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap@sourceware.org
        ReportedBy: mjw@redhat.com
    Classification: Unclassified


cast.exp will fail on s390x with a ERROR: kernel read fault at
0x000000004128dbba (addr) near identifier '@cast' at
.../testsuite/systemtap.base/cast.stp:37:17

This is because that line does:

cast_data = @cast(get_sockaddr(data), "sockaddr", "<sys/socket.h>")->sa_data[0]

make_typequery will see the "<sys/socket.h>" and assume this is a user mode
cast and generates a umod, not a kmod. dwarf_cast_query::handle_query_module()
sees the umod and installs the uderef for user mode address access. This will
then fail (correctly?) fail to access the address as user data.

We could fix the test by using "kernel<linux/socket.h>" which will generate a
kmod instead of a umod. But the comment in the testcase seems to assume you can
use a umod @cast in a begin probe.

I think we should not try to provide user space access in begin/end probes
through casts and the test should be rewritten if it wants to also test umod
casts.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/13440] cast.exp fails on s390x umod cast in (kernel) begin probe

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13440

Mark Wielaard <mjw at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/13440] cast.exp fails on s390x umod cast in (kernel) begin probe

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13440

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|systemtap at sourceware dot |jistone at redhat dot com
                   |org                         |

--- Comment #1 from Josh Stone <jistone at redhat dot com> 2011-11-26 19:08:32 UTC ---
Yes indeed, that test is making an assumption about user memory that doesn't
hold.  I'll have to refactor that piece to a context with a real user
address...

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.