[Bug tapsets/13451] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle dup3

[Bug tapsets/13451] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle dup3

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13451

             Bug #: 13451
           Summary: tapset/nd_syscalls.stp:# FIXME: doesn't handle dup3
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap@sourceware.org
        ReportedBy: mjw@redhat.com
    Classification: Unclassified


The corresponding tapset/syscalls.stp says:
# dup3 (handles both dup2 and dup3 except for corner case)___________

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/13451] tapset/nd_syscalls.stp:# FIXME: doesn't handle dup3

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13451

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com
         Depends on|                            |11424

--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-11-30 16:36:12 UTC ---
Here's a bit more from tapset/syscalls.stp:

----
# dup3 (handles both dup2 and dup3 except for corner case)___________           
# long sys_dup2(unsigned int oldfd, unsigned int newfd)                         
# SYSCALL_DEFINE3(dup3, unsigned int, oldfd, unsigned int, newfd, int, flags)   
probe syscall.dup2 = kernel.function("sys_dup3").call !,                        
                     kernel.function("sys_dup2").call                           
----

The reason why it is done this way is that in the kernel sys_dup2 sets a few
things up then calls sys_dup3.  This way we ignore the sys_dup2 call, and only
catch the sys_dup3 call.

Unfortunately, as bug #11424 notes, '!' (optional and sufficient) doesn't work
for kprobe.function probes.  So, the above logic will be difficult to duplicate
in tapset/nd_syscalls.stp.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/13451] tapset/nd_syscalls.stp:# FIXME: doesn't handle dup3

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13451

Bug 13451 depends on bug 11424, which changed state.

Bug 11424 Summary: dwarfless kprobe.* probes don't validate at translate time
http://sourceware.org/bugzilla/show_bug.cgi?id=11424

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/13451] tapset/nd_syscalls.stp:# FIXME: doesn't handle dup3

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13451

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from David Smith <dsmith at redhat dot com> 2012-07-20 18:58:55 UTC ---
Now that bug #11424 and bug #14378 are fixed, this bug can be addressed.

Fixed in commit bbd3b1b.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.