[Bug tapsets/13453] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_inotify_init1()

[Bug tapsets/13453] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_inotify_init1()

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13453

             Bug #: 13453
           Summary: tapset/nd_syscalls.stp:# FIXME: doesn't handle
                    sys_inotify_init1()
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap@sourceware.org
        ReportedBy: mjw@redhat.com
    Classification: Unclassified


The corresponding syscalls.stp has:

probe syscall.inotify_init = kernel.function("sys_inotify_init1").call !,
                             kernel.function("sys_inotify_init").call ?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/13453] tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_inotify_init1()

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13453

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com
         Depends on|                            |11424

--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-11-30 17:13:22 UTC ---
The reason why it is done this way in syscalls.stp is that in the kernel
sys_inotify_init is just a wrapper around sys_inotify_init1.  This way we
ignore the sys_inotify_init call, and only catch the sys_inotify_init1 call on
kernels with sys_inotify_init1.

Unfortunately, as bug #11424 notes, '!' (optional and sufficient) doesn't work
for kprobe.function probes.  So, the above logic will be difficult to duplicate
in tapset/nd_syscalls.stp.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/13453] tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_inotify_init1()

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13453

Bug 13453 depends on bug 11424, which changed state.

Bug 11424 Summary: dwarfless kprobe.* probes don't validate at translate time
http://sourceware.org/bugzilla/show_bug.cgi?id=11424

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/13453] tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_inotify_init1()

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13453

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from David Smith <dsmith at redhat dot com> 2012-07-20 20:47:14 UTC ---
Now that bug #11424 and bug #14378 are fixed, this bug can be addressed.

Fixed in commit 42f9c99.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.