* [Bug tapsets/13454] New: nd_syscall tapset needs to handle sys_pipe2 and pipe0/pipe1
@ 2011-11-29 19:26 mjw at redhat dot com
2011-11-30 18:40 ` [Bug tapsets/13454] " dsmith at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: mjw at redhat dot com @ 2011-11-29 19:26 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13454
Bug #: 13454
Summary: nd_syscall tapset needs to handle sys_pipe2 and
pipe0/pipe1
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tapsets
AssignedTo: systemtap@sourceware.org
ReportedBy: mjw@redhat.com
Classification: Unclassified
tapset/nd_syscalls2.stp has:
# FIXME: needs to handle sys_pipe2
# FIXME: needs to support pipe0/pipe1
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tapsets/13454] nd_syscall tapset needs to handle sys_pipe2 and pipe0/pipe1
2011-11-29 19:26 [Bug tapsets/13454] New: nd_syscall tapset needs to handle sys_pipe2 and pipe0/pipe1 mjw at redhat dot com
@ 2011-11-30 18:40 ` dsmith at redhat dot com
2012-07-18 18:37 ` dsmith at redhat dot com
2012-07-24 13:16 ` dsmith at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dsmith at redhat dot com @ 2011-11-30 18:40 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13454
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dsmith at redhat dot com
Depends on| |11424
--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-11-30 18:38:48 UTC ---
From syscalls2.stp:
----
# pipe _______________________________________________________
#
# asmlinkage int
# sys_pipe(unsigned long __user * fildes)
#
# SYSCALL_DEFINE2(pipe2, int __user *, fildes, int, flags)
# pipe2() was added to Linux in version 2.6.27.
probe syscall.pipe = kernel.function("sys_pipe2").call !,
kernel.function("sys_ia64_pipe").call ?,
kernel.function("sys_pipe").call
----
The reason why it is done this way is that in the kernel
sys_pipe is just a wrapper around sys_pipe2. This way we
ignore the sys_pipe call, and only catch the sys_pipe2 call on
kernels with sys_pipe2.
Unfortunately, as bug #11424 notes, '!' (optional and sufficient) doesn't work
for kprobe.function probes. So, the above logic will be difficult to duplicate
in tapset/nd_syscalls2.stp.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tapsets/13454] nd_syscall tapset needs to handle sys_pipe2 and pipe0/pipe1
2011-11-29 19:26 [Bug tapsets/13454] New: nd_syscall tapset needs to handle sys_pipe2 and pipe0/pipe1 mjw at redhat dot com
2011-11-30 18:40 ` [Bug tapsets/13454] " dsmith at redhat dot com
@ 2012-07-18 18:37 ` dsmith at redhat dot com
2012-07-24 13:16 ` dsmith at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dsmith at redhat dot com @ 2012-07-18 18:37 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13454
Bug 13454 depends on bug 11424, which changed state.
Bug 11424 Summary: dwarfless kprobe.* probes don't validate at translate time
http://sourceware.org/bugzilla/show_bug.cgi?id=11424
What |Old Value |New Value
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tapsets/13454] nd_syscall tapset needs to handle sys_pipe2 and pipe0/pipe1
2011-11-29 19:26 [Bug tapsets/13454] New: nd_syscall tapset needs to handle sys_pipe2 and pipe0/pipe1 mjw at redhat dot com
2011-11-30 18:40 ` [Bug tapsets/13454] " dsmith at redhat dot com
2012-07-18 18:37 ` dsmith at redhat dot com
@ 2012-07-24 13:16 ` dsmith at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dsmith at redhat dot com @ 2012-07-24 13:16 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13454
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from David Smith <dsmith at redhat dot com> 2012-07-24 13:16:19 UTC ---
Now that bug #11424 and bug #14378 are fixed, this bug can be addressed.
Fixed in commit b1047bc.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-24 13:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-29 19:26 [Bug tapsets/13454] New: nd_syscall tapset needs to handle sys_pipe2 and pipe0/pipe1 mjw at redhat dot com
2011-11-30 18:40 ` [Bug tapsets/13454] " dsmith at redhat dot com
2012-07-18 18:37 ` dsmith at redhat dot com
2012-07-24 13:16 ` dsmith at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).