[Bug tapsets/13479] New: ARM tapset/scheduler.stp refers to kernel.function("__switch_to")

[Bug tapsets/13479] New: ARM tapset/scheduler.stp refers to kernel.function("__switch_to")

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13479

             Bug #: 13479
           Summary: ARM tapset/scheduler.stp refers to
                    kernel.function("__switch_to")
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap@sourceware.org
        ReportedBy: mjw@redhat.com
    Classification: Unclassified


kernel.function("__switch_to") doesn't seem to exist on ARM, but gets selected
in tapset/scheduler.stp because of:

probe __scheduler.ctxswitch.kp =
%( arch != "x86_64" && arch != "ia64" %?
        kernel.function("__switch_to")
%:
        kernel.function("context_switch")
%)

Running /root/systemtap/testsuite/buildok/scheduler-ctxswitch.stp
starting /root/systemtap/testsuite/buildok/scheduler-ctxswitch.stp
spawn1 stap -p4 /root/systemtap/testsuite/buildok/scheduler-ctxswitch.stp
spawn stap -p4 /root/systemtap/testsuite/buildok/scheduler-ctxswitch.stp
semantic error: no match while resolving probe point
kernel.function("__switch_to")
semantic error: no match while resolving probe point
kernel.function("__switch_to")
semantic error: no match while resolving probe point __scheduler.ctxswitch.kp

semantic error: no match while resolving probe point __scheduler.ctxswitch.kp
Pass 2: analysis failed.  Try again with another '--vp 01' option.

Pass 2: analysis failed.  Try again with another '--vp 01' option.
wait results: 1471 exp16 0 1
KFAIL: buildok/scheduler-ctxswitch.stp (PRMS: GCC)

Hmmmm, that isn't really a KFAIL...
But the same is true for:
Running /root/systemtap/testsuite/systemtap.stress/current.exp ...
executing: stap -v -g /root/systemtap/testsuite/systemtap.stress/current.stp
spawn stap -v -g /root/systemtap/testsuite/systemtap.stress/current.stp
Pass 1: parsed user script and 75 library script(s) using
16592virt/12656res/161
6shr kb, in 710usr/10sys/717real ms.
semantic error: no match while resolving probe point
kernel.function("__switch_to").callFAIL: systemtap.stress/current.stp
compilation
testcase /root/systemtap/testsuite/systemtap.stress/current.exp completed in 3
seconds

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/13479] ARM tapset/scheduler.stp refers to kernel.function("__switch_to")

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13479

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-12-07 15:54:31 UTC ---
Does the kernel function 'context_switch' exist for arm?  (stap -L
'kernel.function("context_switch")'

If so, adding arm to the arch exclusion list for "__switch_to" should fix this.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/13479] ARM tapset/scheduler.stp refers to kernel.function("__switch_to")

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13479

Mark Wielaard <mjw at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Mark Wielaard <mjw at redhat dot com> 2011-12-17 01:33:44 UTC ---
Although this actual testcase was already fixed by the recent rewrite of the
tapset/scheduler.stp probe scheduler.ctxswitch, and that works because my
kernel setup has the kernel.trace("sched_switch") available, I still made the
arch selection change because arm does indeed have
kernel.function("context_switch"), not kernel.function("__switch_to").

commit a5f655a7ebb86195123ffd12a544ce65bf050747
Author: Mark Wielaard <mjw@redhat.com>
Date:   Sat Dec 17 02:32:57 2011 +0100

    scheduler.ctxswitch: arm has context_switch(), not __switch_to().

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.