[Bug translator/13486] pass-4 error (frame_base undeclared), inlined function argument

["jistone at redhat dot com" <sourceware-bugzilla@sourceware.org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=13486

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Josh Stone <jistone at redhat dot com> 2012-09-27 16:52:41 UTC ---
(In reply to comment #3)
> I think your patch handles this correctly. But you could consider moving the
> check up into the for (l = loc; l != NULL; l = l->next) loop just above it that
> checks the types. You can probably just check whether to output the frame_base
> at the same time instead of looping through the location chain twice. Although
> the chains aren't very deep, so it probably doesn't matter.

Thanks for checking.  I did consider moving it into the loop you mention, but
decided not to for two reasons.  First, I didn't want to perturb the relative
order of the addr and frame_base declarations.  Second, we only want a single
frame_base declaration, even if multiple parts of the chain use it, so if we
can't break the loop, then another tracking variable is needed.  It seems
simpler to add a new loop iteration just for the frame_base.

Pushed as commit b0b86028.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.