[Bug runtime/13645] New: isolate strftime to stapio

[Bug runtime/13645] New: isolate strftime to stapio

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13645

             Bug #: 13645
           Summary: isolate strftime to stapio
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap@sourceware.org
        ReportedBy: jistone@redhat.com
    Classification: Unclassified


The -o option for staprun/stapio supports strftime formatting in its argument
to name the output files by localtime.  Since this is a user-provided format
string, we have to relax gcc with -Wno-format-nonliteral.

The output files are opened by stapio, so it will have to use this format.  But
staprun only processes the format during the parse_args() validation.  If we
refactor the strftime call to only stapio, then we can isolate the relaxed
warning too, and leave the setuid staprun as tight as possible.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/13645] isolate strftime to stapio

[quae at daurnimator dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13645

daurnimator <quae at daurnimator dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |quae at daurnimator dot com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/13645] isolate strftime to stapio

[jistone at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13645

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Josh Stone <jistone at redhat dot com> ---
FWIW, commit 0a5f4aa83e5b (release-2.5~389^2~44) did reduce that warning to
just one small object file that calls strftime, leaving the rest fully warned. 
This isolated function is still called by staprun though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/13645] isolate strftime to stapio

[jistone at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=13645

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #2 from Josh Stone <jistone at redhat dot com> ---
(edit: sorry, didn't mean to close it yet)

-- 
You are receiving this mail because:
You are the assignee for the bug.