* [Bug tapsets/13694] New: on rhel6, tcp.sendmsg returns incorrect "sock" local variable
@ 2012-02-15 16:59 dsmith at redhat dot com
2012-02-15 17:05 ` [Bug tapsets/13694] " dsmith at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: dsmith at redhat dot com @ 2012-02-15 16:59 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13694
Bug #: 13694
Summary: on rhel6, tcp.sendmsg returns incorrect "sock" local
variable
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tapsets
AssignedTo: systemtap@sourceware.org
ReportedBy: dsmith@redhat.com
Classification: Unclassified
The tcp.sendmsg probe alias looks like this:
probe tcp.sendmsg = kernel.function("tcp_sendmsg") {
name = "tcp.sendmsg"
sock = (@defined($sock) ? $sock : $sk)
size = $size
}
However, $sock and $sk have different types as shown by the following table:
OS tcp.sendmsg tcp.rcvmsg
======== ===================== ================
rhel5 $sk:struct sock* $sk:struct sock*
rhel6 $sock:struct socket * $sk:struct sock*
rawhide $sk:struct sock * $sk:struct sock*
So, if a script uses the tcp.sendmsg probe alias on RHEL6, the "sock" local
variable will have the wrong type.
That tcp.sendmsg line should have been (since the 'sk' field of the 'struct
socket' is a 'struct sock *'):
sock = (@defined($sock) ? $sock->sk : $sk)
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug tapsets/13694] on rhel6, tcp.sendmsg returns incorrect "sock" local variable
2012-02-15 16:59 [Bug tapsets/13694] New: on rhel6, tcp.sendmsg returns incorrect "sock" local variable dsmith at redhat dot com
@ 2012-02-15 17:05 ` dsmith at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: dsmith at redhat dot com @ 2012-02-15 17:05 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13694
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #1 from David Smith <dsmith at redhat dot com> 2012-02-15 17:04:14 UTC ---
Fixed in commit 627afdc.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-15 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-15 16:59 [Bug tapsets/13694] New: on rhel6, tcp.sendmsg returns incorrect "sock" local variable dsmith at redhat dot com
2012-02-15 17:05 ` [Bug tapsets/13694] " dsmith at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).