[Bug translator/13998] New: pretty-printing bitfields shouldn't use %c

[Bug translator/13998] New: pretty-printing bitfields shouldn't use %c

[fche at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13998

             Bug #: 13998
           Summary: pretty-printing bitfields shouldn't use %c
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap@sourceware.org
        ReportedBy: fche@redhat.com
    Classification: Unclassified


bitfields in structs are pretty-printed with formatting type %c, whereas most
likely it should be %u.

% stap -e 'probe kernel.function("audit_log_end") { println($ab->skb$) }' -v
-p2 | grep sprint

return sprintf("{.next=%p, .prev=%p, .tstamp={...}, .sk=%p, .dev=%p, .cb=[...],
._skb_refdst=%u, .sp=%p, .len=%u, .data_len=%u, .mac_len=%u, .hdr_len=%u,
<union>={...}, .priority=%u, .local_df='%c', .cloned='%c', .ip_summed='%c',
.nohdr='%c', .nfctinfo='%c', .pkt_type='%c', .fclone='%c', .ipvs_property='%c',
.peeked='%c', .nf_trace='%c', .protocol=%u, .destructor=%p, .nfct=%p,
.nfct_reasm=%p, .nf_bridge=%p, .skb_iif=%i, .tc_index=%u, .tc_verd=%u,
.rxhash=%u, .queue_mapping=%u, .ndisc_nodetype='%c', ...} [...]


local_df is a 1-bit bitfield in struct skbuff.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug translator/13998] pretty-printing bitfields shouldn't use %c

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13998

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jistone at redhat dot com
         AssignedTo|systemtap at sourceware dot |jistone at redhat dot com
                   |org                         |

--- Comment #1 from Josh Stone <jistone at redhat dot com> 2012-04-19 18:48:05 UTC ---
The basic problem is that dwarf_pretty_print::recurse is looking at type DIEs,
but the DWARF bit attributes are only on the struct member DIE.  We'll need to
treat this as a special case from recurse_struct_members to notice when a
char-like base type is really a bitfield.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.